* [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region
@ 2020-05-12 20:45 Rob Herring
2020-05-13 12:10 ` Mark Brown
2020-05-13 21:22 ` Paul Walmsley
0 siblings, 2 replies; 5+ messages in thread
From: Rob Herring @ 2020-05-12 20:45 UTC (permalink / raw)
To: devicetree
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, linux-spi,
Mark Brown, Palmer Dabbelt, Paul Walmsley, linux-riscv, linux-clk
The 'reg' description and example have a 2nd register region for memory
mapped flash, but the schema says there is only 1 region. Fix this.
Cc: Mark Brown <broonie@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Please ack, dependency for patch 5.
Documentation/devicetree/bindings/spi/spi-sifive.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-sifive.yaml b/Documentation/devicetree/bindings/spi/spi-sifive.yaml
index 28040598bfae..fb583e57c1f2 100644
--- a/Documentation/devicetree/bindings/spi/spi-sifive.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sifive.yaml
@@ -32,11 +32,10 @@ properties:
https://github.com/sifive/sifive-blocks/tree/master/src/main/scala/devices/spi
reg:
- maxItems: 1
-
- description:
- Physical base address and size of SPI registers map
- A second (optional) range can indicate memory mapped flash
+ minItems: 1
+ items:
+ - description: SPI registers region
+ - description: Memory mapped flash region
interrupts:
maxItems: 1
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region
2020-05-12 20:45 [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region Rob Herring
@ 2020-05-13 12:10 ` Mark Brown
2020-05-13 13:02 ` Rob Herring
2020-05-13 21:22 ` Paul Walmsley
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2020-05-13 12:10 UTC (permalink / raw)
To: Rob Herring, devicetree
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, linux-spi,
Palmer Dabbelt, Paul Walmsley, linux-riscv, linux-clk
On Tue, 12 May 2020 15:45:39 -0500, Rob Herring wrote:
> The 'reg' description and example have a 2nd register region for memory
> mapped flash, but the schema says there is only 1 region. Fix this.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.8
Thanks!
[1/1] spi: dt-bindings: sifive: Add missing 2nd register region
commit: b265b5a0ba15b6e00abce9bf162926e84b4323b4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region
2020-05-13 12:10 ` Mark Brown
@ 2020-05-13 13:02 ` Rob Herring
2020-05-13 14:03 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2020-05-13 13:02 UTC (permalink / raw)
To: Mark Brown
Cc: devicetree, Greg Kroah-Hartman, Linux USB List,
linux-kernel@vger.kernel.org, linux-spi, Palmer Dabbelt,
Paul Walmsley, linux-riscv, linux-clk
On Wed, May 13, 2020 at 7:10 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, 12 May 2020 15:45:39 -0500, Rob Herring wrote:
> > The 'reg' description and example have a 2nd register region for memory
> > mapped flash, but the schema says there is only 1 region. Fix this.
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.8
>
> Thanks!
>
> [1/1] spi: dt-bindings: sifive: Add missing 2nd register region
> commit: b265b5a0ba15b6e00abce9bf162926e84b4323b4
You missed my ask for an ack. This is a dependency for patch 5.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region
2020-05-13 13:02 ` Rob Herring
@ 2020-05-13 14:03 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-05-13 14:03 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Greg Kroah-Hartman, Linux USB List,
linux-kernel@vger.kernel.org, linux-spi, Palmer Dabbelt,
Paul Walmsley, linux-riscv, linux-clk
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
On Wed, May 13, 2020 at 08:02:14AM -0500, Rob Herring wrote:
> On Wed, May 13, 2020 at 7:10 AM Mark Brown <broonie@kernel.org> wrote:
> > [1/1] spi: dt-bindings: sifive: Add missing 2nd register region
> > commit: b265b5a0ba15b6e00abce9bf162926e84b4323b4
> You missed my ask for an ack. This is a dependency for patch 5.
Ah, there was no cover letter.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region
2020-05-12 20:45 [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region Rob Herring
2020-05-13 12:10 ` Mark Brown
@ 2020-05-13 21:22 ` Paul Walmsley
1 sibling, 0 replies; 5+ messages in thread
From: Paul Walmsley @ 2020-05-13 21:22 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Greg Kroah-Hartman, linux-usb, linux-kernel,
linux-spi, Mark Brown, Palmer Dabbelt, linux-riscv, linux-clk
On Tue, 12 May 2020, Rob Herring wrote:
> The 'reg' description and example have a 2nd register region for memory
> mapped flash, but the schema says there is only 1 region. Fix this.
>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: linux-spi@vger.kernel.org
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please ack, dependency for patch 5.
Acked-by: Paul Walmsley <paul.walmsley@sifive.com>
- Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 21:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 20:45 [PATCH 1/5] spi: dt-bindings: sifive: Add missing 2nd register region Rob Herring
2020-05-13 12:10 ` Mark Brown
2020-05-13 13:02 ` Rob Herring
2020-05-13 14:03 ` Mark Brown
2020-05-13 21:22 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox