From: Conor Dooley <conor.dooley@microchip.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] RISC-V: Fix up some vector state related build failures
Date: Tue, 20 Jun 2023 08:33:57 +0100 [thread overview]
Message-ID: <20230620-bagging-swerve-07dbcea6adbc@wendy> (raw)
In-Reply-To: <20230619172101.18692-1-palmer@rivosinc.com>
[-- Attachment #1.1: Type: text/plain, Size: 1866 bytes --]
On Mon, Jun 19, 2023 at 10:21:01AM -0700, Palmer Dabbelt wrote:
> I get a few build failures along the lines of
>
> ./arch/riscv/include/uapi/asm/sigcontext.h:19:36: error: field ‘v_state’ has incomplete type
> 19 | struct __riscv_v_ext_state v_state;
> | ^~~~~~~
> ./arch/riscv/include/uapi/asm/sigcontext.h:32:49: error: field ‘sc_extdesc’ has incomplete type
> 32 | struct __riscv_extra_ext_header sc_extdesc;
>
> The V structures in question are defined for !assembly, so let's just do
> so for the others.
>
> Fixes: 8ee0b41898fa ("riscv: signal: Add sigcontext save/restore for vector")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Not the first time you've caught this sort of problem in headers, is
there a particular build that catches these?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> arch/riscv/include/uapi/asm/sigcontext.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/include/uapi/asm/sigcontext.h b/arch/riscv/include/uapi/asm/sigcontext.h
> index 8b8a8541673a..8c8712aa9551 100644
> --- a/arch/riscv/include/uapi/asm/sigcontext.h
> +++ b/arch/riscv/include/uapi/asm/sigcontext.h
> @@ -15,6 +15,8 @@
> /* The size of END signal context header. */
> #define END_HDR_SIZE 0x0
>
> +#ifndef __ASSEMBLY__
> +
> struct __sc_riscv_v_state {
> struct __riscv_v_ext_state v_state;
> } __attribute__((aligned(16)));
> @@ -33,4 +35,6 @@ struct sigcontext {
> };
> };
>
> +#endif /*!__ASSEMBLY__*/
> +
> #endif /* _UAPI_ASM_RISCV_SIGCONTEXT_H */
> --
> 2.40.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-20 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 17:21 [PATCH] RISC-V: Fix up some vector state related build failures Palmer Dabbelt
2023-06-20 7:33 ` Conor Dooley [this message]
2023-06-25 23:23 ` Palmer Dabbelt
2023-07-04 15:02 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620-bagging-swerve-07dbcea6adbc@wendy \
--to=conor.dooley@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox