* Re: linux-next: Tree for Oct 6 (riscv: andes) [not found] <20231006153809.2054a0f8@canb.auug.org.au> @ 2023-10-07 0:28 ` Randy Dunlap 2023-10-07 10:56 ` Conor Dooley 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2023-10-07 0:28 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, linux-riscv, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou [-- Attachment #1: Type: text/plain, Size: 724 bytes --] On 10/5/23 21:38, Stephen Rothwell wrote: > Hi all, > > Changes since 20231005: > on riscv 64bit: WARNING: unmet direct dependencies detected for ERRATA_ANDES Depends on [n]: RISCV_ALTERNATIVE [=n] && RISCV_SBI [=y] Selected by [y]: - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y] && NONPORTABLE [=y] && RISCV_SBI [=y] ../arch/riscv/errata/andes/errata.c:59:54: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration 59 | void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end, | ^~~~~~~~~ Full randconfig file is attached. -- ~Randy [-- Attachment #2: config-r8419.gz --] [-- Type: application/gzip, Size: 33131 bytes --] [-- Attachment #3: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Oct 6 (riscv: andes) 2023-10-07 0:28 ` linux-next: Tree for Oct 6 (riscv: andes) Randy Dunlap @ 2023-10-07 10:56 ` Conor Dooley 2023-10-07 16:06 ` Randy Dunlap 0 siblings, 1 reply; 3+ messages in thread From: Conor Dooley @ 2023-10-07 10:56 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, linux-riscv, Paul Walmsley, Palmer Dabbelt, Albert Ou [-- Attachment #1.1: Type: text/plain, Size: 1635 bytes --] On Fri, Oct 06, 2023 at 05:28:27PM -0700, Randy Dunlap wrote: > > > On 10/5/23 21:38, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20231005: > > > > on riscv 64bit: > > WARNING: unmet direct dependencies detected for ERRATA_ANDES > Depends on [n]: RISCV_ALTERNATIVE [=n] && RISCV_SBI [=y] > Selected by [y]: > - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y] && NONPORTABLE [=y] && RISCV_SBI [=y] > > ../arch/riscv/errata/andes/errata.c:59:54: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration > 59 | void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end, > | ^~~~~~~~~ > > > Full randconfig file is attached. Riiight. XIP_KERNEL is enabled, which means no alternatives are permitted, but that R9A config option selects the Andes errata, which in turn depends on alternatives. I suppose we could do something like (untested): diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index 7b74de732718..6fe85255e2ce 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -343,7 +343,7 @@ config ARCH_R9A07G043 select ARCH_RZG2L select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT select DMA_GLOBAL_POOL - select ERRATA_ANDES if RISCV_SBI + select ERRATA_ANDES if (RISCV_SBI & RISCV_ALTERNATIVE) select ERRATA_ANDES_CMO if ERRATA_ANDES help This enables support for the Renesas RZ/Five SoC. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Oct 6 (riscv: andes) 2023-10-07 10:56 ` Conor Dooley @ 2023-10-07 16:06 ` Randy Dunlap 0 siblings, 0 replies; 3+ messages in thread From: Randy Dunlap @ 2023-10-07 16:06 UTC (permalink / raw) To: Conor Dooley Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, linux-riscv, Paul Walmsley, Palmer Dabbelt, Albert Ou Hi Conor, On 10/7/23 03:56, Conor Dooley wrote: > On Fri, Oct 06, 2023 at 05:28:27PM -0700, Randy Dunlap wrote: >> >> >> On 10/5/23 21:38, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20231005: >>> >> >> on riscv 64bit: >> >> WARNING: unmet direct dependencies detected for ERRATA_ANDES >> Depends on [n]: RISCV_ALTERNATIVE [=n] && RISCV_SBI [=y] >> Selected by [y]: >> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y] && NONPORTABLE [=y] && RISCV_SBI [=y] >> >> ../arch/riscv/errata/andes/errata.c:59:54: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration >> 59 | void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end, >> | ^~~~~~~~~ >> >> >> Full randconfig file is attached. > > Riiight. XIP_KERNEL is enabled, which means no alternatives are > permitted, but that R9A config option selects the Andes errata, which in > turn depends on alternatives. > > I suppose we could do something like (untested): > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig > index 7b74de732718..6fe85255e2ce 100644 > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -343,7 +343,7 @@ config ARCH_R9A07G043 > select ARCH_RZG2L > select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT > select DMA_GLOBAL_POOL > - select ERRATA_ANDES if RISCV_SBI > + select ERRATA_ANDES if (RISCV_SBI & RISCV_ALTERNATIVE) s/&/&&/ and then this works. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> > select ERRATA_ANDES_CMO if ERRATA_ANDES > help > This enables support for the Renesas RZ/Five SoC. -- ~Randy _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-07 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231006153809.2054a0f8@canb.auug.org.au>
2023-10-07 0:28 ` linux-next: Tree for Oct 6 (riscv: andes) Randy Dunlap
2023-10-07 10:56 ` Conor Dooley
2023-10-07 16:06 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox