From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c)
Date: Wed, 13 Dec 2023 08:37:59 +1100 [thread overview]
Message-ID: <20231213083759.738f0798@canb.auug.org.au> (raw)
In-Reply-To: <CAHVXubitXvkWmvHd7JXs5kTZC4L2VvOD2B_ue3D5hUhevOpwfA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]
Hi all,
On Tue, 12 Dec 2023 08:24:54 +0100 Alexandre Ghiti <alexghiti@rivosinc.com> wrote:
>
> On Mon, Dec 11, 2023 at 10:22 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on riscv32:
> >
> > ../drivers/perf/riscv_pmu_sbi.c:1015:35: error: initialization of 'int (*)(const struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int, void *, unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int, void *, unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
> > 1015 | .proc_handler = riscv_pmu_proc_user_access_handler,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../drivers/perf/riscv_pmu_sbi.c:1015:35: note: (near initialization for 'sbi_pmu_sysctl_table[0].proc_handler')
>
> I already sent a fix for that here:
> https://lore.kernel.org/all/20231207083512.51792-1-alexghiti@rivosinc.com/
I have added that patch to linux-next today and will keep it until it
turns up in the sysctl tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2023-12-12 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231211172504.058ad6b6@canb.auug.org.au>
2023-12-11 21:17 ` linux-next: Tree for Dec 11 (riscv32: patch.c) Randy Dunlap
2023-12-12 8:01 ` Alexandre Ghiti
2023-12-13 12:57 ` Conor Dooley
2023-12-13 13:33 ` Alexandre Ghiti
2023-12-14 10:05 ` Alexandre Ghiti
2023-12-11 21:22 ` linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c) Randy Dunlap
2023-12-12 7:24 ` Alexandre Ghiti
2023-12-12 21:37 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213083759.738f0798@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alexghiti@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox