* Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
[not found] <20231211172504.058ad6b6@canb.auug.org.au>
@ 2023-12-11 21:17 ` Randy Dunlap
2023-12-12 8:01 ` Alexandre Ghiti
2023-12-11 21:22 ` linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c) Randy Dunlap
1 sibling, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2023-12-11 21:17 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-riscv, Alexandre Ghiti,
Palmer Dabbelt
[-- Attachment #1: Type: text/plain, Size: 2757 bytes --]
On 12/10/23 22:25, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20231208:
>
on riscv32:
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
patch.c:(.text+0xd2): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
patch.c:(.text+0x202): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
patch.c:(.text+0x410): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
patch.c:(.text+0x550): undefined reference to `__exittext_end'
/opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
Full randconfig file is attached.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
[-- Attachment #2: config-r3585.gz --]
[-- Type: application/gzip, Size: 34710 bytes --]
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c)
[not found] <20231211172504.058ad6b6@canb.auug.org.au>
2023-12-11 21:17 ` linux-next: Tree for Dec 11 (riscv32: patch.c) Randy Dunlap
@ 2023-12-11 21:22 ` Randy Dunlap
2023-12-12 7:24 ` Alexandre Ghiti
1 sibling, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2023-12-11 21:22 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-riscv, Alexandre Ghiti
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On 12/10/23 22:25, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20231208:
>
on riscv32:
../drivers/perf/riscv_pmu_sbi.c:1015:35: error: initialization of 'int (*)(const struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int, void *, unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int, void *, unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
1015 | .proc_handler = riscv_pmu_proc_user_access_handler,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/perf/riscv_pmu_sbi.c:1015:35: note: (near initialization for 'sbi_pmu_sysctl_table[0].proc_handler')
Full randconfig file is attached.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
[-- Attachment #2: config-r3583.gz --]
[-- Type: application/gzip, Size: 39318 bytes --]
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c)
2023-12-11 21:22 ` linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c) Randy Dunlap
@ 2023-12-12 7:24 ` Alexandre Ghiti
2023-12-12 21:37 ` Stephen Rothwell
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Ghiti @ 2023-12-12 7:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv
Hi Randy,
On Mon, Dec 11, 2023 at 10:22 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 12/10/23 22:25, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231208:
> >
>
> on riscv32:
>
> ../drivers/perf/riscv_pmu_sbi.c:1015:35: error: initialization of 'int (*)(const struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int, void *, unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int, void *, unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
> 1015 | .proc_handler = riscv_pmu_proc_user_access_handler,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/perf/riscv_pmu_sbi.c:1015:35: note: (near initialization for 'sbi_pmu_sysctl_table[0].proc_handler')
>
>
>
> Full randconfig file is attached.
I already sent a fix for that here:
https://lore.kernel.org/all/20231207083512.51792-1-alexghiti@rivosinc.com/
Thanks!
Alex
>
>
> --
> #Randy
> https://people.kernel.org/tglx/notes-about-netiquette
> https://subspace.kernel.org/etiquette.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
2023-12-11 21:17 ` linux-next: Tree for Dec 11 (riscv32: patch.c) Randy Dunlap
@ 2023-12-12 8:01 ` Alexandre Ghiti
2023-12-13 12:57 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Ghiti @ 2023-12-12 8:01 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, Palmer Dabbelt
Hi Randy,
On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 12/10/23 22:25, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231208:
> >
>
> on riscv32:
>
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> patch.c:(.text+0x202): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> patch.c:(.text+0x550): undefined reference to `__exittext_end'
> /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
>
>
> Full randconfig file is attached.
We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
that I'll remove this soon.
Thanks,
Alex
>
> --
> #Randy
> https://people.kernel.org/tglx/notes-about-netiquette
> https://subspace.kernel.org/etiquette.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c)
2023-12-12 7:24 ` Alexandre Ghiti
@ 2023-12-12 21:37 ` Stephen Rothwell
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2023-12-12 21:37 UTC (permalink / raw)
To: Alexandre Ghiti
Cc: Randy Dunlap, Linux Next Mailing List, Linux Kernel Mailing List,
linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]
Hi all,
On Tue, 12 Dec 2023 08:24:54 +0100 Alexandre Ghiti <alexghiti@rivosinc.com> wrote:
>
> On Mon, Dec 11, 2023 at 10:22 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on riscv32:
> >
> > ../drivers/perf/riscv_pmu_sbi.c:1015:35: error: initialization of 'int (*)(const struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(const struct ctl_table *, int, void *, unsigned int *, long long int *)'} from incompatible pointer type 'int (*)(struct ctl_table *, int, void *, size_t *, loff_t *)' {aka 'int (*)(struct ctl_table *, int, void *, unsigned int *, long long int *)'} [-Werror=incompatible-pointer-types]
> > 1015 | .proc_handler = riscv_pmu_proc_user_access_handler,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../drivers/perf/riscv_pmu_sbi.c:1015:35: note: (near initialization for 'sbi_pmu_sysctl_table[0].proc_handler')
>
> I already sent a fix for that here:
> https://lore.kernel.org/all/20231207083512.51792-1-alexghiti@rivosinc.com/
I have added that patch to linux-next today and will keep it until it
turns up in the sysctl tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
2023-12-12 8:01 ` Alexandre Ghiti
@ 2023-12-13 12:57 ` Conor Dooley
2023-12-13 13:33 ` Alexandre Ghiti
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-12-13 12:57 UTC (permalink / raw)
To: Alexandre Ghiti
Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, Palmer Dabbelt
[-- Attachment #1.1: Type: text/plain, Size: 3237 bytes --]
On Tue, Dec 12, 2023 at 09:01:17AM +0100, Alexandre Ghiti wrote:
> Hi Randy,
>
> On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> >
> >
> > On 12/10/23 22:25, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20231208:
> > >
> >
> > on riscv32:
> >
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> > patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> > patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> > patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> > patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> > patch.c:(.text+0x202): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> > patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> > patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> > patch.c:(.text+0x550): undefined reference to `__exittext_end'
> > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
> >
> >
> > Full randconfig file is attached.
>
> We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
> that I'll remove this soon.
I don't think we can (even if people hadn't sent patches yesterday for
XIP) act as if XIP being removed is a foregone conclusion.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
2023-12-13 12:57 ` Conor Dooley
@ 2023-12-13 13:33 ` Alexandre Ghiti
2023-12-14 10:05 ` Alexandre Ghiti
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Ghiti @ 2023-12-13 13:33 UTC (permalink / raw)
To: Conor Dooley
Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, Palmer Dabbelt
On Wed, Dec 13, 2023 at 1:57 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Dec 12, 2023 at 09:01:17AM +0100, Alexandre Ghiti wrote:
> > Hi Randy,
> >
> > On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> > >
> > >
> > >
> > > On 12/10/23 22:25, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20231208:
> > > >
> > >
> > > on riscv32:
> > >
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> > > patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> > > patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> > > patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> > > patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> > > patch.c:(.text+0x202): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> > > patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> > > patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> > > patch.c:(.text+0x550): undefined reference to `__exittext_end'
> > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
> > >
> > >
> > > Full randconfig file is attached.
> >
> > We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
> > that I'll remove this soon.
>
> I don't think we can (even if people hadn't sent patches yesterday for
> XIP) act as if XIP being removed is a foregone conclusion.
Ok, the fix is easy enough for me to send it right now, so I'll fix that :)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Dec 11 (riscv32: patch.c)
2023-12-13 13:33 ` Alexandre Ghiti
@ 2023-12-14 10:05 ` Alexandre Ghiti
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Ghiti @ 2023-12-14 10:05 UTC (permalink / raw)
To: Conor Dooley
Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-riscv, Palmer Dabbelt
On Wed, Dec 13, 2023 at 2:33 PM Alexandre Ghiti <alexghiti@rivosinc.com> wrote:
>
> On Wed, Dec 13, 2023 at 1:57 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Dec 12, 2023 at 09:01:17AM +0100, Alexandre Ghiti wrote:
> > > Hi Randy,
> > >
> > > On Mon, Dec 11, 2023 at 10:17 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> > > >
> > > >
> > > >
> > > > On 12/10/23 22:25, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20231208:
> > > > >
> > > >
> > > > on riscv32:
> > > >
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L4':
> > > > patch.c:(.text+0xbe): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xc2): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L12':
> > > > patch.c:(.text+0xd2): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0xd6): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L15':
> > > > patch.c:(.text+0x1ea): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L7':
> > > > patch.c:(.text+0x1ee): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x1fe): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L22':
> > > > patch.c:(.text+0x202): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `__patch_insn_write':
> > > > patch.c:(.text+0x410): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x414): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x424): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x428): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L46':
> > > > patch.c:(.text+0x53c): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x540): undefined reference to `__exittext_begin'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: arch/riscv/kernel/patch.o: in function `.L48':
> > > > patch.c:(.text+0x550): undefined reference to `__exittext_end'
> > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: patch.c:(.text+0x554): undefined reference to `__exittext_end'
> > > >
> > > >
> > > > Full randconfig file is attached.
> > >
> > > We can ignore this one as CONFIG_XIP is enabled and we agreed at LPC
> > > that I'll remove this soon.
> >
> > I don't think we can (even if people hadn't sent patches yesterday for
> > XIP) act as if XIP being removed is a foregone conclusion.
>
> Ok, the fix is easy enough for me to send it right now, so I'll fix that :)
The fix is here
https://patchwork.kernel.org/project/linux-riscv/patch/20231214091926.203439-1-alexghiti@rivosinc.com/
and I asked Palmer to replace the v1 he already had in -fixes with
this new version, hopefully it will land in rc6.
Thanks,
Alex
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-14 10:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231211172504.058ad6b6@canb.auug.org.au>
2023-12-11 21:17 ` linux-next: Tree for Dec 11 (riscv32: patch.c) Randy Dunlap
2023-12-12 8:01 ` Alexandre Ghiti
2023-12-13 12:57 ` Conor Dooley
2023-12-13 13:33 ` Alexandre Ghiti
2023-12-14 10:05 ` Alexandre Ghiti
2023-12-11 21:22 ` linux-next: Tree for Dec 11 (drivers/perf/riscv_pmu_sbi.c) Randy Dunlap
2023-12-12 7:24 ` Alexandre Ghiti
2023-12-12 21:37 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox