Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] riscv: dts: sifive: add missing #interrupt-cells to pmic
@ 2024-02-13 19:47 Conor Dooley
  2024-02-13 21:49 ` Samuel Holland
  0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2024-02-13 19:47 UTC (permalink / raw)
  To: linux-riscv; +Cc: conor, Conor Dooley

From: Conor Dooley <conor.dooley@microchip.com>

At W=2 dtc complains:
hifive-unmatched-a00.dts:120.10-238.4: Warning (interrupt_provider): /soc/i2c@10030000/pmic@58: Missing '#interrupt-cells' in interrupt provider

Add the missing property.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 07387f9c135c..72b87b08ab44 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -123,6 +123,7 @@ pmic@58 {
 		interrupt-parent = <&gpio>;
 		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;
+		#interrupt-cells = <2>;
 
 		onkey {
 			compatible = "dlg,da9063-onkey";
-- 
2.43.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: dts: sifive: add missing #interrupt-cells to pmic
  2024-02-13 19:47 [PATCH] riscv: dts: sifive: add missing #interrupt-cells to pmic Conor Dooley
@ 2024-02-13 21:49 ` Samuel Holland
  2024-02-14  9:10   ` Conor Dooley
  0 siblings, 1 reply; 3+ messages in thread
From: Samuel Holland @ 2024-02-13 21:49 UTC (permalink / raw)
  To: Conor Dooley, linux-riscv; +Cc: Conor Dooley

On 2024-02-13 1:47 PM, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> At W=2 dtc complains:
> hifive-unmatched-a00.dts:120.10-238.4: Warning (interrupt_provider): /soc/i2c@10030000/pmic@58: Missing '#interrupt-cells' in interrupt provider
> 
> Add the missing property.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Samuel Holland <samuel.holland@sifive.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: dts: sifive: add missing #interrupt-cells to pmic
  2024-02-13 21:49 ` Samuel Holland
@ 2024-02-14  9:10   ` Conor Dooley
  0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-02-14  9:10 UTC (permalink / raw)
  To: Samuel Holland; +Cc: linux-riscv, Conor Dooley


[-- Attachment #1.1: Type: text/plain, Size: 650 bytes --]

On Tue, Feb 13, 2024 at 03:49:53PM -0600, Samuel Holland wrote:
> On 2024-02-13 1:47 PM, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > At W=2 dtc complains:
> > hifive-unmatched-a00.dts:120.10-238.4: Warning (interrupt_provider): /soc/i2c@10030000/pmic@58: Missing '#interrupt-cells' in interrupt provider
> > 
> > Add the missing property.
> > 
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Samuel Holland <samuel.holland@sifive.com>

Applied so, thanks :)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-14  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 19:47 [PATCH] riscv: dts: sifive: add missing #interrupt-cells to pmic Conor Dooley
2024-02-13 21:49 ` Samuel Holland
2024-02-14  9:10   ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox