public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] irqchip/riscv-imsic: Fix output text of base address
@ 2024-09-09  8:56 Andrew Jones
  2024-09-09 10:55 ` Anup Patel
  2024-11-12 22:53 ` patchwork-bot+linux-riscv
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jones @ 2024-09-09  8:56 UTC (permalink / raw)
  To: linux-riscv, linux-kernel; +Cc: anup, tglx, paul.walmsley, palmer, aou

The "per-CPU IDs ... at base ..." info log is outputting a physical
address, not a PPN.

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 11723a763c10..c5ec66e0bfd3 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
 		imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
 	pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
 		imsic->fwnode, global->group_index_bits, global->group_index_shift);
-	pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+	pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
 		imsic->fwnode, global->nr_ids, &global->base_addr);
 	pr_info("%pfwP: total %d interrupts available\n",
 		imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
-- 
2.46.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip/riscv-imsic: Fix output text of base address
  2024-09-09  8:56 [PATCH] irqchip/riscv-imsic: Fix output text of base address Andrew Jones
@ 2024-09-09 10:55 ` Anup Patel
  2024-11-12 22:53 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2024-09-09 10:55 UTC (permalink / raw)
  To: Andrew Jones; +Cc: linux-riscv, linux-kernel, tglx, paul.walmsley, palmer, aou

On Mon, Sep 9, 2024 at 2:26 PM Andrew Jones <ajones@ventanamicro.com> wrote:
>
> The "per-CPU IDs ... at base ..." info log is outputting a physical
> address, not a PPN.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
> index 11723a763c10..c5ec66e0bfd3 100644
> --- a/drivers/irqchip/irq-riscv-imsic-platform.c
> +++ b/drivers/irqchip/irq-riscv-imsic-platform.c
> @@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
>                 imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
>         pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
>                 imsic->fwnode, global->group_index_bits, global->group_index_shift);
> -       pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
> +       pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
>                 imsic->fwnode, global->nr_ids, &global->base_addr);
>         pr_info("%pfwP: total %d interrupts available\n",
>                 imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
> --
> 2.46.0
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] irqchip/riscv-imsic: Fix output text of base address
  2024-09-09  8:56 [PATCH] irqchip/riscv-imsic: Fix output text of base address Andrew Jones
  2024-09-09 10:55 ` Anup Patel
@ 2024-11-12 22:53 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-11-12 22:53 UTC (permalink / raw)
  To: Andrew Jones
  Cc: linux-riscv, linux-kernel, anup, tglx, paul.walmsley, palmer, aou

Hello:

This patch was applied to riscv/linux.git (fixes)
by Thomas Gleixner <tglx@linutronix.de>:

On Mon,  9 Sep 2024 10:56:11 +0200 you wrote:
> The "per-CPU IDs ... at base ..." info log is outputting a physical
> address, not a PPN.
> 
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> ---
>  drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - irqchip/riscv-imsic: Fix output text of base address
    https://git.kernel.org/riscv/c/4a1361e9a5c5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-12 22:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09  8:56 [PATCH] irqchip/riscv-imsic: Fix output text of base address Andrew Jones
2024-09-09 10:55 ` Anup Patel
2024-11-12 22:53 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox