[PATCH] riscv: dts: sophgo: fix pinctrl base-address

[PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Thomas Bonnefille]

Fix the base-address of the pinctrl controller to match its register
address.

Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
---
 arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/sophgo/sg2002.dtsi b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
--- a/arch/riscv/boot/dts/sophgo/sg2002.dtsi
+++ b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
@@ -16,7 +16,7 @@ memory@80000000 {
 	};
 
 	soc {
-		pinctrl: pinctrl@3008000 {
+		pinctrl: pinctrl@3001000 {
 			compatible = "sophgo,sg2002-pinctrl";
 			reg = <0x03001000 0x1000>,
 			      <0x05027000 0x1000>;

---
base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c

Best regards,
-- 
Thomas Bonnefille <thomas.bonnefille@bootlin.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Chen Wang]

Hello~, Thomas

This problem is introduced by this patchset [1], which is still on the 
sophgo/for-next branch and has not been submitted to the main line. So I 
think the right thing to do is to submit another version v6 with your 
bugfix.

Link: 
https://lore.kernel.org/linux-riscv/20241010-sg2002-v5-0-a0f2e582b932@bootlin.com/ 
[1]

Thanks,

Chen

On 2024/10/28 18:43, Thomas Bonnefille wrote:
> Fix the base-address of the pinctrl controller to match its register
> address.
>
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> ---
>   arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2002.dtsi b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> @@ -16,7 +16,7 @@ memory@80000000 {
>   	};
>   
>   	soc {
> -		pinctrl: pinctrl@3008000 {
> +		pinctrl: pinctrl@3001000 {
>   			compatible = "sophgo,sg2002-pinctrl";
>   			reg = <0x03001000 0x1000>,
>   			      <0x05027000 0x1000>;
>
> ---
> base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
> change-id: 20241028-fix-address-e7f0c40eac2c
>
> Best regards,

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Inochi Amaoto]

On Tue, Oct 29, 2024 at 07:34:41AM +0800, Chen Wang wrote:
> Hello~, Thomas
> 
> This problem is introduced by this patchset [1], which is still on the
> sophgo/for-next branch and has not been submitted to the main line. So I
> think the right thing to do is to submit another version v6 with your
> bugfix.
> 

It is OK to let this patch go. If we want to keep the patch persisent,
it is better to apply a fix than revoke the fault one and apply a new
version.

Regards,
Inochi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Inochi Amaoto]

On Mon, Oct 28, 2024 at 11:43:24AM +0100, Thomas Bonnefille wrote:
> Fix the base-address of the pinctrl controller to match its register
> address.
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> ---
>  arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/sg2002.dtsi b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2002.dtsi
> @@ -16,7 +16,7 @@ memory@80000000 {
>  	};
>  
>  	soc {
> -		pinctrl: pinctrl@3008000 {
> +		pinctrl: pinctrl@3001000 {
>  			compatible = "sophgo,sg2002-pinctrl";
>  			reg = <0x03001000 0x1000>,
>  			      <0x05027000 0x1000>;
> 
> ---
> base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
> change-id: 20241028-fix-address-e7f0c40eac2c
> 
> Best regards,
> -- 
> Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> 

Reviewed-by: Inochi Amaoto <inochiama@gmail.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Inochi Amaoto]

On Mon, Oct 28, 2024 at 11:43:24AM +0100, Thomas Bonnefille wrote:
> Fix the base-address of the pinctrl controller to match its register
> address.
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

Fixes: 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Chen Wang]

Hi, Inochi,

Will you pick this on sophgo/for-next?

Regards,

Chen

On 2024/10/30 11:50, Inochi Amaoto wrote:
> On Mon, Oct 28, 2024 at 11:43:24AM +0100, Thomas Bonnefille wrote:
>> Fix the base-address of the pinctrl controller to match its register
>> address.
>>
>> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> Fixes: 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Inochi Amaoto]

On Sat, Nov 02, 2024 at 06:28:50AM +0800, Chen Wang wrote:
> Hi, Inochi,
> 
> Will you pick this on sophgo/for-next?
> 
> Regards,
> 
> Chen
> 
> On 2024/10/30 11:50, Inochi Amaoto wrote:
> > On Mon, Oct 28, 2024 at 11:43:24AM +0100, Thomas Bonnefille wrote:
> > > Fix the base-address of the pinctrl controller to match its register
> > > address.
> > > 
> > > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> > Fixes: 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")
> > 

Yeah, I have quened this patch and will merge it once I have
space time, so please wait.

Regards,
Inochi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] riscv: dts: sophgo: fix pinctrl base-address

[Inochi Amaoto]

On Mon, 28 Oct 2024 11:43:24 +0100, Thomas Bonnefille wrote:
> Fix the base-address of the pinctrl controller to match its register
> address.
> 
> 

Applied to for-next, thanks!

[1/1] riscv: dts: sophgo: fix pinctrl base-address
      https://github.com/sophgo/linux/commit/44196383a26fcacbd6dcf5a1ab2dd8bf8e4132c0

Thanks,
Inochi


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv