From: Conor Dooley <conor@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] pwm: Strengthen dependency for PWM_SIFIVE
Date: Tue, 18 Feb 2025 16:42:18 +0000 [thread overview]
Message-ID: <20250218-only-banshee-035249898ef8@spud> (raw)
In-Reply-To: <ts5ze4fosj2vg6pokjfqx3tjernjug646kihiqikxfrhk7tzbl@whgq4nuhni4r>
[-- Attachment #1.1: Type: text/plain, Size: 1016 bytes --]
On Sat, Feb 15, 2025 at 03:48:43PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jan 27, 2025 at 11:50:01AM +0100, Uwe Kleine-König wrote:
> > Back when the sifive pwm driver was added there was no symbol for sifive
> > SoCs yet. Today there is ARCH_SIFIVE however. Let PWM_SIFIVE depend on
> > that to ensure the driver is only build for platforms where there is a
> > chance that the hardware is available.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> > a quick grep suggests that the driver is only used on machines that include
> > arch/riscv/boot/dts/sifive/fu540-c000.dtsi or
> > arch/riscv/boot/dts/sifive/fu740-c000.dtsi and for these ARCH_SIFIVE is
> > enabled. So I'd guess this patch is fine. Still an ack from someone who
> > knows this arch better would be very welcome.
>
> Applied now without further feedback to
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
Bit late, but ye I think that's fair.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2025-02-18 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 10:50 [PATCH] pwm: Strengthen dependency for PWM_SIFIVE Uwe Kleine-König
2025-02-15 14:48 ` Uwe Kleine-König
2025-02-18 16:42 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218-only-banshee-035249898ef8@spud \
--to=conor@kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox