[PATCH] pwm: Strengthen dependency for PWM_SIFIVE

[PATCH] pwm: Strengthen dependency for PWM_SIFIVE

[Uwe Kleine-König]

Back when the sifive pwm driver was added there was no symbol for sifive
SoCs yet. Today there is ARCH_SIFIVE however. Let PWM_SIFIVE depend on
that to ensure the driver is only build for platforms where there is a
chance that the hardware is available.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,

a quick grep suggests that the driver is only used on machines that include
arch/riscv/boot/dts/sifive/fu540-c000.dtsi or
arch/riscv/boot/dts/sifive/fu740-c000.dtsi and for these ARCH_SIFIVE is
enabled. So I'd guess this patch is fine. Still an ack from someone who
knows this arch better would be very welcome.

Best regards
Uwe

 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 0915c1e7df16..be0db73003e4 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -567,7 +567,7 @@ config PWM_SIFIVE
 	tristate "SiFive PWM support"
 	depends on OF
 	depends on COMMON_CLK && HAS_IOMEM
-	depends on RISCV || COMPILE_TEST
+	depends on ARCH_SIFIVE || COMPILE_TEST
 	help
 	  Generic PWM framework driver for SiFive SoCs.
 
-- 
2.47.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] pwm: Strengthen dependency for PWM_SIFIVE

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]

Hello,

On Mon, Jan 27, 2025 at 11:50:01AM +0100, Uwe Kleine-König wrote:
> Back when the sifive pwm driver was added there was no symbol for sifive
> SoCs yet. Today there is ARCH_SIFIVE however. Let PWM_SIFIVE depend on
> that to ensure the driver is only build for platforms where there is a
> chance that the hardware is available.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> a quick grep suggests that the driver is only used on machines that include
> arch/riscv/boot/dts/sifive/fu540-c000.dtsi or
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi and for these ARCH_SIFIVE is
> enabled. So I'd guess this patch is fine. Still an ack from someone who
> knows this arch better would be very welcome.

Applied now without further feedback to
	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

.

Best regards
Uwe

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] pwm: Strengthen dependency for PWM_SIFIVE

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1016 bytes --]

On Sat, Feb 15, 2025 at 03:48:43PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Jan 27, 2025 at 11:50:01AM +0100, Uwe Kleine-König wrote:
> > Back when the sifive pwm driver was added there was no symbol for sifive
> > SoCs yet. Today there is ARCH_SIFIVE however. Let PWM_SIFIVE depend on
> > that to ensure the driver is only build for platforms where there is a
> > chance that the hardware is available.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> > a quick grep suggests that the driver is only used on machines that include
> > arch/riscv/boot/dts/sifive/fu540-c000.dtsi or
> > arch/riscv/boot/dts/sifive/fu740-c000.dtsi and for these ARCH_SIFIVE is
> > enabled. So I'd guess this patch is fine. Still an ack from someone who
> > knows this arch better would be very welcome.
> 
> Applied now without further feedback to
> 	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

Bit late, but ye I think that's fair.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv