Re: [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1

From: Yixun Lan <dlan@gentoo.org>
To: pabeni@redhat.com
Cc: Vivian Wang <wangruikang@iscas.ac.cn>,
	andrew+netdev@lunn.ch, kuba@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, p.zabel@pengutronix.de,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, uwu@dram.page,
	vadim.fedorenko@linux.dev, junhui.liu@pigmoral.tech,
	horms@kernel.org, maxime.chevallier@bootlin.com,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org, conor.dooley@microchip.com,
	troy.mitchell@linux.spacemit.com,
	hendrik.hamerlinck@hammernet.be, andrew@lunn.ch
Subject: Re: [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1
Date: Tue, 16 Sep 2025 20:20:26 +0800	[thread overview]
Message-ID: <20250916122026-GYB1255161@gentoo.org> (raw)
In-Reply-To: <175802161326.713595.16381910315366172301.git-patchwork-notify@kernel.org>

Hi Paolo Abeni,

Thanks for taking this series, but I have one comment (see below)

On 11:20 Tue 16 Sep     , patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This series was applied to netdev/net-next.git (main)
> by Paolo Abeni <pabeni@redhat.com>:
> 
> On Sun, 14 Sep 2025 12:23:11 +0800 you wrote:
> > SpacemiT K1 has two gigabit Ethernet MACs with RGMII and RMII support.
> > Add devicetree bindings, driver, and DTS for it.
> > 
> > Tested primarily on BananaPi BPI-F3. Basic TX/RX functionality also
> > tested on Milk-V Jupiter.
> > 
> > I would like to note that even though some bit field names superficially
> > resemble that of DesignWare MAC, all other differences point to it in
> > fact being a custom design.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net-next,v12,1/5] dt-bindings: net: Add support for SpacemiT K1
>     https://git.kernel.org/netdev/net-next/c/62a12a221769
>   - [net-next,v12,2/5] net: spacemit: Add K1 Ethernet MAC
>     https://git.kernel.org/netdev/net-next/c/bfec6d7f2001
..
>   - [net-next,v12,3/5] riscv: dts: spacemit: Add Ethernet support for K1
>     https://git.kernel.org/netdev/net-next/c/60775f28cfb7
>   - [net-next,v12,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
>     https://git.kernel.org/netdev/net-next/c/3c247a6366d5
>   - [net-next,v12,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter
>     https://git.kernel.org/netdev/net-next/c/e32dc7a936b1
> 

Generally, I'd expect the DT part patch (3-5) to go via SpacemiT's SoC tree[1],
so, this will avoid potential conflicts..

Can you drop patch 3-5? then I will take care of them, plus there is one more
patch in my queue..

Link: https://github.com/spacemit-com/linux/tree/k1/dt-for-next [1]

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv