From: Andrew Lunn <andrew@lunn.ch>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Vivian Wang <uwu@dram.page>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Junhui Liu <junhui.liu@pigmoral.tech>,
Simon Horman <horms@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org,
Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Subject: Re: [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
Date: Sun, 14 Sep 2025 16:26:46 +0200 [thread overview]
Message-ID: <6ace8fca-21db-40f1-b44d-28e4a1d3d2da@lunn.ch> (raw)
In-Reply-To: <007c08ab-b432-463f-abd8-215371e117c4@iscas.ac.cn>
On Sun, Sep 14, 2025 at 12:31:04PM +0800, Vivian Wang wrote:
> On 9/14/25 12:23, Vivian Wang wrote:
> > Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
> > reset.
> >
> > Tested-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
> > Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
> > Reviewed-by: Yixun Lan <dlan@gentoo.org>
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++
> > 1 file changed, 48 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..33e223cefd4bd3a12fae176ac6cddd8276cb53dc 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> > @@ -11,6 +11,8 @@ / {
> > compatible = "bananapi,bpi-f3", "spacemit,k1";
> >
> > aliases {
> > + ethernet0 = ð0;
> > + ethernet1 = ð1;
>
> Hi Andrew,
>
> I added these two aliases in v12, but kept your Reviewed-by for v11
> because this is fairly trivial. Same for patch 5.
>
> Is this okay?
Yes, this is fine.
Andrew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-14 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250919082706eucas1p1fa29f9e90e1afdf3894b5effd734cf3f@eucas1p1.samsung.com>
2025-09-14 4:23 ` [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1 Vivian Wang
2025-09-14 4:23 ` [PATCH net-next v12 1/5] dt-bindings: net: Add " Vivian Wang
2025-09-14 4:23 ` [PATCH net-next v12 2/5] net: spacemit: Add K1 Ethernet MAC Vivian Wang
2025-09-14 4:23 ` [PATCH net-next v12 3/5] riscv: dts: spacemit: Add Ethernet support for K1 Vivian Wang
2025-09-14 4:23 ` [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3 Vivian Wang
2025-09-14 4:31 ` Vivian Wang
2025-09-14 14:26 ` Andrew Lunn [this message]
2025-09-14 4:23 ` [PATCH net-next v12 5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter Vivian Wang
2025-09-14 10:30 ` [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1 Yixun Lan
2025-09-16 11:20 ` patchwork-bot+netdevbpf
2025-09-16 12:20 ` Yixun Lan
2025-09-19 8:27 ` Marek Szyprowski
2025-09-19 8:53 ` Vivian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ace8fca-21db-40f1-b44d-28e4a1d3d2da@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex@ghiti.fr \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=hendrik.hamerlinck@hammernet.be \
--cc=horms@kernel.org \
--cc=junhui.liu@pigmoral.tech \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=uwu@dram.page \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox