* Re: [PATCH 2/2] cpuidle: riscv-sbi: Replace deprecated strcpy in sbi_cpuidle_init_cpu
2025-10-21 13:51 ` [PATCH 2/2] cpuidle: riscv-sbi: Replace deprecated strcpy in sbi_cpuidle_init_cpu Thorsten Blum
@ 2025-10-28 6:16 ` Paul Walmsley
2025-10-28 9:58 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2025-10-28 6:16 UTC (permalink / raw)
To: Thorsten Blum
Cc: Anup Patel, Rafael J. Wysocki, Daniel Lezcano, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-pm, linux-riscv,
linux-kernel
On Tue, 21 Oct 2025, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Thanks, I'll plan to queue this one through arch/riscv fixes - unless
you'd prefer to take it, Daniel?
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] cpuidle: riscv-sbi: Replace deprecated strcpy in sbi_cpuidle_init_cpu
2025-10-21 13:51 ` [PATCH 2/2] cpuidle: riscv-sbi: Replace deprecated strcpy in sbi_cpuidle_init_cpu Thorsten Blum
2025-10-28 6:16 ` Paul Walmsley
@ 2025-10-28 9:58 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2025-10-28 9:58 UTC (permalink / raw)
To: Thorsten Blum
Cc: Rafael J. Wysocki, Daniel Lezcano, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Alexandre Ghiti, linux-pm, linux-riscv, linux-kernel
On Tue, Oct 21, 2025 at 7:22 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> strcpy() is deprecated; use strscpy() instead.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
LGTM.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> drivers/cpuidle/cpuidle-riscv-sbi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-riscv-sbi.c b/drivers/cpuidle/cpuidle-riscv-sbi.c
> index a360bc4d20b7..19be6475d356 100644
> --- a/drivers/cpuidle/cpuidle-riscv-sbi.c
> +++ b/drivers/cpuidle/cpuidle-riscv-sbi.c
> @@ -18,6 +18,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/slab.h>
> +#include <linux/string.h>
> #include <linux/platform_device.h>
> #include <linux/pm_domain.h>
> #include <linux/pm_runtime.h>
> @@ -303,8 +304,8 @@ static int sbi_cpuidle_init_cpu(struct device *dev, int cpu)
> drv->states[0].exit_latency = 1;
> drv->states[0].target_residency = 1;
> drv->states[0].power_usage = UINT_MAX;
> - strcpy(drv->states[0].name, "WFI");
> - strcpy(drv->states[0].desc, "RISC-V WFI");
> + strscpy(drv->states[0].name, "WFI");
> + strscpy(drv->states[0].desc, "RISC-V WFI");
>
> /*
> * If no DT idle states are detected (ret == 0) let the driver
> --
> 2.51.0
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread