Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter
@ 2025-12-06 13:44 Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 1/3] riscv: dts: spacemit: Enable i2c8 adapter " Javier Martinez Canillas
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2025-12-06 13:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Alex Elder, Javier Martinez Canillas, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley,
	Rob Herring, Yixun Lan, devicetree, linux-riscv, spacemit

Hello,

This patch series enables the i2c8 adapter, the PMIC, and voltage regulators
for the Milk-V Jupiter board.

The power management hardware design on the Milk-V Jupiter is identical to the
Banana Pi BPI-F3, so the DT Nodes were copied from the k1-bananapi-f3.dts file.

I have verified the I2C address and regulator constraints against the vendor's
downstream DTS to ensure accuracy. I have also dumped the regulator_summary
debugfs entry to check that the regulators and constraints are registered:

$ cat /sys/kernel/debug/regulator/regulator_summary
 regulator                      use open bypass  opmode voltage current     min     max
---------------------------------------------------------------------------------------
 regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
 dc_in_12v                        2    1      0 unknown 12000mV     0mA 12000mV 12000mV
    vcc_4v                        7   10      0 unknown  4000mV     0mA  4000mV  4000mV
       buck1                      1    0      0 unknown  1050mV     0mA   500mV  3425mV
       buck2                      1    0      0 unknown   900mV     0mA   500mV  3425mV
       buck3                      1    0      0 unknown  1800mV     0mA   500mV  1800mV
       buck4                      1    0      0 unknown  3300mV     0mA   500mV  3300mV
       buck5                      3    7      0 unknown  2100mV     0mA   500mV  3425mV
          dldo1                   0    0      0 unknown  1200mV     0mA   500mV  3125mV
          dldo2                   0    0      0 unknown   500mV     0mA   500mV  3125mV
          dldo3                   0    0      0 unknown   500mV     0mA   500mV  3125mV
          dldo4                   1    0      0 unknown  1800mV     0mA   500mV  3125mV
          dldo5                   0    0      0 unknown   500mV     0mA   500mV  3125mV
          dldo6                   1    0      0 unknown  1800mV     0mA   500mV  3125mV
          dldo7                   0    0      0 unknown   500mV     0mA   500mV  3125mV
       buck6                      1    0      0 unknown  1100mV     0mA   500mV  3425mV
       aldo1                      0    0      0 unknown  1800mV     0mA   500mV  3125mV
       aldo2                      0    0      0 unknown   500mV     0mA   500mV  3125mV
       aldo3                      0    0      0 unknown   500mV     0mA   500mV  3125mV
       aldo4                      0    0      0 unknown   500mV     0mA   500mV  3125mV

Best regards,
Javier


Javier Martinez Canillas (3):
  riscv: dts: spacemit: Enable i2c8 adapter for Milk-V Jupiter
  riscv: dts: spacemit: Define fixed regulators for Milk-V Jupiter
  riscv: dts: spacemit: Define the P1 PMIC regulators for Milk-V Jupiter

 .../boot/dts/spacemit/k1-milkv-jupiter.dts    | 135 ++++++++++++++++++
 1 file changed, 135 insertions(+)

-- 
2.52.0

base-commit: bb3a1f127972ea262f98eee55068de1e54ab8d57
branch: milkv-jupiter-pmic


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] riscv: dts: spacemit: Enable i2c8 adapter for Milk-V Jupiter
  2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
@ 2025-12-06 13:44 ` Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 2/3] riscv: dts: spacemit: Define fixed regulators " Javier Martinez Canillas
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2025-12-06 13:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Alex Elder, Javier Martinez Canillas, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley,
	Rob Herring, Yixun Lan, devicetree, linux-riscv, spacemit

The adapter is used to access the SpacemiT P1 PMIC present in this board.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
index 28afd39b28da..aa425f02c1f4 100644
--- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
@@ -72,6 +72,12 @@ &pdma {
 	status = "okay";
 };
 
+&i2c8 {
+	pinctrl-0 = <&i2c8_cfg>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
-- 
2.52.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] riscv: dts: spacemit: Define fixed regulators for Milk-V Jupiter
  2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 1/3] riscv: dts: spacemit: Enable i2c8 adapter " Javier Martinez Canillas
@ 2025-12-06 13:44 ` Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 3/3] riscv: dts: spacemit: Define the P1 PMIC " Javier Martinez Canillas
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2025-12-06 13:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Alex Elder, Javier Martinez Canillas, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley,
	Rob Herring, Yixun Lan, devicetree, linux-riscv, spacemit

Define the DC power input and the 4v power as fixed regulator supplies.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 .../boot/dts/spacemit/k1-milkv-jupiter.dts    | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
index aa425f02c1f4..5babed4d7094 100644
--- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
@@ -20,6 +20,25 @@ aliases {
 	chosen {
 		stdout-path = "serial0";
 	};
+
+	reg_dc_in: dc-in-12v {
+		compatible = "regulator-fixed";
+		regulator-name = "dc_in_12v";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	reg_vcc_4v: vcc-4v {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_4v";
+		regulator-min-microvolt = <4000000>;
+		regulator-max-microvolt = <4000000>;
+		regulator-boot-on;
+		regulator-always-on;
+		vin-supply = <&reg_dc_in>;
+	};
 };
 
 &eth0 {
-- 
2.52.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] riscv: dts: spacemit: Define the P1 PMIC regulators for Milk-V Jupiter
  2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 1/3] riscv: dts: spacemit: Enable i2c8 adapter " Javier Martinez Canillas
  2025-12-06 13:44 ` [PATCH 2/3] riscv: dts: spacemit: Define fixed regulators " Javier Martinez Canillas
@ 2025-12-06 13:44 ` Javier Martinez Canillas
  2025-12-19 11:39 ` [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints " Yixun Lan
  2025-12-19 21:42 ` Yixun Lan
  4 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2025-12-06 13:44 UTC (permalink / raw)
  To: linux-kernel
  Cc: Alex Elder, Javier Martinez Canillas, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley,
	Rob Herring, Yixun Lan, devicetree, linux-riscv, spacemit

Define the SpacemiT P1 PMIC voltage regulators and their constraints.

The power management hardware design on the Milk-V Jupiter is identical to
the Banana Pi BPI-F3, so the DT Nodes were taken from k1-bananapi-f3.dts.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 .../boot/dts/spacemit/k1-milkv-jupiter.dts    | 110 ++++++++++++++++++
 1 file changed, 110 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
index 5babed4d7094..800a112d5d70 100644
--- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
@@ -95,6 +95,116 @@ &i2c8 {
 	pinctrl-0 = <&i2c8_cfg>;
 	pinctrl-names = "default";
 	status = "okay";
+
+	pmic@41 {
+		compatible = "spacemit,p1";
+		reg = <0x41>;
+		interrupts = <64>;
+		vin-supply = <&reg_vcc_4v>;
+
+		regulators {
+			buck1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck2 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck3_1v8: buck3 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck4 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck5 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck6 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3450000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			aldo1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+			};
+
+			aldo2 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			aldo3 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			aldo4 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			dldo1 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-boot-on;
+			};
+
+			dldo2 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			dldo3 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			dldo4 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-always-on;
+			};
+
+			dldo5 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			dldo6 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+				regulator-always-on;
+			};
+
+			dldo7 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+		};
+	};
 };
 
 &uart0 {
-- 
2.52.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter
  2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
                   ` (2 preceding siblings ...)
  2025-12-06 13:44 ` [PATCH 3/3] riscv: dts: spacemit: Define the P1 PMIC " Javier Martinez Canillas
@ 2025-12-19 11:39 ` Yixun Lan
  2025-12-19 21:42 ` Yixun Lan
  4 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2025-12-19 11:39 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Alex Elder, Albert Ou, Alexandre Ghiti,
	Conor Dooley, Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley,
	Rob Herring, devicetree, linux-riscv, spacemit


On 14:44 Sat 06 Dec     , Javier Martinez Canillas wrote:
> Hello,
> 
> This patch series enables the i2c8 adapter, the PMIC, and voltage regulators
> for the Milk-V Jupiter board.
> 
> The power management hardware design on the Milk-V Jupiter is identical to the
> Banana Pi BPI-F3, so the DT Nodes were copied from the k1-bananapi-f3.dts file.
> 
> I have verified the I2C address and regulator constraints against the vendor's
> downstream DTS to ensure accuracy. I have also dumped the regulator_summary
> debugfs entry to check that the regulators and constraints are registered:
> 
> $ cat /sys/kernel/debug/regulator/regulator_summary
>  regulator                      use open bypass  opmode voltage current     min     max
> ---------------------------------------------------------------------------------------
>  regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
>  dc_in_12v                        2    1      0 unknown 12000mV     0mA 12000mV 12000mV
>     vcc_4v                        7   10      0 unknown  4000mV     0mA  4000mV  4000mV
>        buck1                      1    0      0 unknown  1050mV     0mA   500mV  3425mV
>        buck2                      1    0      0 unknown   900mV     0mA   500mV  3425mV
>        buck3                      1    0      0 unknown  1800mV     0mA   500mV  1800mV
>        buck4                      1    0      0 unknown  3300mV     0mA   500mV  3300mV
>        buck5                      3    7      0 unknown  2100mV     0mA   500mV  3425mV
>           dldo1                   0    0      0 unknown  1200mV     0mA   500mV  3125mV
>           dldo2                   0    0      0 unknown   500mV     0mA   500mV  3125mV
>           dldo3                   0    0      0 unknown   500mV     0mA   500mV  3125mV
>           dldo4                   1    0      0 unknown  1800mV     0mA   500mV  3125mV
>           dldo5                   0    0      0 unknown   500mV     0mA   500mV  3125mV
>           dldo6                   1    0      0 unknown  1800mV     0mA   500mV  3125mV
>           dldo7                   0    0      0 unknown   500mV     0mA   500mV  3125mV
>        buck6                      1    0      0 unknown  1100mV     0mA   500mV  3425mV
>        aldo1                      0    0      0 unknown  1800mV     0mA   500mV  3125mV
>        aldo2                      0    0      0 unknown   500mV     0mA   500mV  3125mV
>        aldo3                      0    0      0 unknown   500mV     0mA   500mV  3125mV
>        aldo4                      0    0      0 unknown   500mV     0mA   500mV  3125mV
> 
> Best regards,
> Javier
> 
> 
> Javier Martinez Canillas (3):
>   riscv: dts: spacemit: Enable i2c8 adapter for Milk-V Jupiter
>   riscv: dts: spacemit: Define fixed regulators for Milk-V Jupiter
>   riscv: dts: spacemit: Define the P1 PMIC regulators for Milk-V Jupiter
> 
>  .../boot/dts/spacemit/k1-milkv-jupiter.dts    | 135 ++++++++++++++++++
>  1 file changed, 135 insertions(+)
> 
The series looks good, I will queue it, thanks

Reviewed-by: Yixun Lan <dlan@gentoo.org>

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter
  2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
                   ` (3 preceding siblings ...)
  2025-12-19 11:39 ` [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints " Yixun Lan
@ 2025-12-19 21:42 ` Yixun Lan
  4 siblings, 0 replies; 6+ messages in thread
From: Yixun Lan @ 2025-12-19 21:42 UTC (permalink / raw)
  To: linux-kernel, Javier Martinez Canillas
  Cc: Yixun Lan, Alex Elder, Albert Ou, Alexandre Ghiti, Conor Dooley,
	Krzysztof Kozlowski, Palmer Dabbelt, Paul Walmsley, Rob Herring,
	devicetree, linux-riscv, spacemit


On Sat, 06 Dec 2025 14:44:52 +0100, Javier Martinez Canillas wrote:
> This patch series enables the i2c8 adapter, the PMIC, and voltage regulators
> for the Milk-V Jupiter board.
> 
> The power management hardware design on the Milk-V Jupiter is identical to the
> Banana Pi BPI-F3, so the DT Nodes were copied from the k1-bananapi-f3.dts file.
> 
> I have verified the I2C address and regulator constraints against the vendor's
> downstream DTS to ensure accuracy. I have also dumped the regulator_summary
> debugfs entry to check that the regulators and constraints are registered:
> 
> [...]

Applied, thanks!

[1/3] riscv: dts: spacemit: Enable i2c8 adapter for Milk-V Jupiter
      https://github.com/spacemit-com/linux/commit/f33ccc2316304f3a71e40e53f1568e75042b0a4b
[2/3] riscv: dts: spacemit: Define fixed regulators for Milk-V Jupiter
      https://github.com/spacemit-com/linux/commit/ae9d03f8aec76c1bff21083b67c211238d7c57b1
[3/3] riscv: dts: spacemit: Define the P1 PMIC regulators for Milk-V Jupiter
      https://github.com/spacemit-com/linux/commit/7d307daa12b15a97269f577d5dcf50518758b568

Best regards,
-- 
Yixun Lan


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-12-19 21:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-06 13:44 [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints for Milk-V Jupiter Javier Martinez Canillas
2025-12-06 13:44 ` [PATCH 1/3] riscv: dts: spacemit: Enable i2c8 adapter " Javier Martinez Canillas
2025-12-06 13:44 ` [PATCH 2/3] riscv: dts: spacemit: Define fixed regulators " Javier Martinez Canillas
2025-12-06 13:44 ` [PATCH 3/3] riscv: dts: spacemit: Define the P1 PMIC " Javier Martinez Canillas
2025-12-19 11:39 ` [PATCH 0/3] riscv: dts: spacemit: Add PMIC and regulators constraints " Yixun Lan
2025-12-19 21:42 ` Yixun Lan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox