From: fangyu.yu@linux.alibaba.com
To: andrew.jones@oss.qualcomm.com
Cc: ajones@ventanamicro.com, alex@ghiti.fr, aou@eecs.berkeley.edu,
fangyu.yu@linux.alibaba.com, guoren@kernel.org,
iommu@lists.linux.dev, joro@8bytes.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@dabbelt.com, pjw@kernel.org, robin.murphy@arm.com,
tjeznach@rivosinc.com, will@kernel.org
Subject: Re: Re: [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries
Date: Sat, 17 Jan 2026 12:31:49 +0800 [thread overview]
Message-ID: <20260117043149.76084-1-fangyu.yu@linux.alibaba.com> (raw)
In-Reply-To: <q2jjixx6imiwdwlxiu4cnh6nghnueivjge5d4jscor5q6yx2el@lxujpebn3nsx>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 796 bytes --]
>On Fri, Jan 16, 2026 at 02:12:06PM -0600, Andrew Jones wrote:
>...
>> > @@ -1055,6 +1135,11 @@ static void riscv_iommu_iodir_update(struct riscv_iommu_device *iommu,
>> > /* Invalidate device context after update */
>> > riscv_iommu_cmd_iodir_inval_ddt(&cmd);
>> > riscv_iommu_cmd_iodir_set_did(&cmd, fwspec->ids[i]);
>> > + /*
>> > + * For now, the SVA and PASID features have not yet been merged, the
>> > + * default configuration is inval_pdt=false and pc=NULL.
>> > + */
>> > + riscv_iommu_iodir_iotinval(iommu, false, dc->iohgatp, dc, NULL);
>
>Shouldn't this iotinval come after the cmd-send below?
Yes, that's a typo on my side.
I’ll fix in v2.
>
>> > riscv_iommu_cmd_send(iommu, &cmd);
>> > }
>> >
>> > --
>> > 2.50.1
>> >
>
>Thanks,
>drew
>
Thanks,
Fangyu
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-17 4:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 13:48 [PATCH] iommu/riscv: Add IOTINVAL after updating DDT/PDT entries fangyu.yu
2026-01-16 20:12 ` Andrew Jones
2026-01-16 21:23 ` Andrew Jones
2026-01-17 4:31 ` fangyu.yu [this message]
2026-01-17 4:31 ` fangyu.yu
2026-01-18 13:48 ` Guo Ren
2026-01-18 13:54 ` Guo Ren
2026-01-18 14:33 ` fangyu.yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117043149.76084-1-fangyu.yu@linux.alibaba.com \
--to=fangyu.yu@linux.alibaba.com \
--cc=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=andrew.jones@oss.qualcomm.com \
--cc=aou@eecs.berkeley.edu \
--cc=guoren@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tjeznach@rivosinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox