From: Conor Dooley <conor@kernel.org>
To: Jia Wang <wangjia@ultrarisc.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
"Zhang Xincheng" <zhangxincheng@ultrarisc.com>
Subject: Re: [PATCH 1/2] riscv: ultrarisc: 8250_dw: support DP1000 uart
Date: Mon, 16 Mar 2026 11:22:16 +0000 [thread overview]
Message-ID: <20260316-frayed-pretended-eba059554dcc@spud> (raw)
In-Reply-To: <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com>
[-- Attachment #1.1: Type: text/plain, Size: 2778 bytes --]
On Mon, Mar 16, 2026 at 09:36:18AM +0800, Jia Wang wrote:
> From: Zhang Xincheng <zhangxincheng@ultrarisc.com>
>
> The UART of DP1000 does not support automatic detection of
> buffer size. skip_autocfg needs to be set to true
>
> Signed-off-by: Zhang Xincheng <zhangxincheng@ultrarisc.com>
> Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
$subject: riscv: ultrarisc: 8250_dw: support DP1000 uart
Please update this to match other modifications to this file.
"riscv: ultrariscv" doesn't belong at the start.
> ---
> drivers/tty/serial/8250/8250_dw.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index db73b2ae17fa..6a2acf173331 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -56,6 +56,7 @@
> #define DW_UART_QUIRK_IS_DMA_FC BIT(3)
> #define DW_UART_QUIRK_APMC0D08 BIT(4)
> #define DW_UART_QUIRK_CPR_VALUE BIT(5)
> +#define DW_UART_QUIRK_FIXED_TYPE BIT(6)
>
> struct dw8250_platform_data {
> u8 usr_reg;
> @@ -514,6 +515,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
> data->data.dma.prepare_tx_dma = dw8250_prepare_tx_dma;
> data->data.dma.prepare_rx_dma = dw8250_prepare_rx_dma;
> }
> + if (quirks & DW_UART_QUIRK_FIXED_TYPE) {
> + p->flags |= UPF_FIXED_TYPE;
> + p->type = PORT_16550A;
> + data->skip_autocfg = true;
> + }
> if (quirks & DW_UART_QUIRK_APMC0D08) {
> p->iotype = UPIO_MEM32;
> p->regshift = 2;
> @@ -789,6 +795,11 @@ static const struct dw8250_platform_data dw8250_skip_set_rate_data = {
> .quirks = DW_UART_QUIRK_SKIP_SET_RATE,
> };
>
> +static const struct dw8250_platform_data dw8250_ultrarisc_dp1000_data = {
> + .usr_reg = DW_UART_USR,
> + .quirks = DW_UART_QUIRK_FIXED_TYPE,
> +};
> +
> static const struct of_device_id dw8250_of_match[] = {
> { .compatible = "snps,dw-apb-uart", .data = &dw8250_dw_apb },
> { .compatible = "cavium,octeon-3860-uart", .data = &dw8250_octeon_3860_data },
> @@ -796,6 +807,7 @@ static const struct of_device_id dw8250_of_match[] = {
> { .compatible = "renesas,rzn1-uart", .data = &dw8250_renesas_rzn1_data },
> { .compatible = "sophgo,sg2044-uart", .data = &dw8250_skip_set_rate_data },
> { .compatible = "starfive,jh7100-uart", .data = &dw8250_skip_set_rate_data },
> + { .compatible = "ultrarisc,dp1000-uart", .data = &dw8250_ultrarisc_dp1000_data },
> { /* Sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, dw8250_of_match);
>
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-16 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 1:36 [PATCH 0/2] serial: 8250_dw: Add support for UltraRISC DP1000 uart Jia Wang
2026-03-16 1:36 ` [PATCH 1/2] riscv: ultrarisc: 8250_dw: support " Jia Wang
2026-03-16 11:22 ` Conor Dooley [this message]
2026-03-16 1:36 ` [PATCH 2/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart Jia Wang
2026-03-16 4:39 ` Yao Zi
2026-03-16 6:19 ` Jia Wang
2026-03-16 11:20 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316-frayed-pretended-eba059554dcc@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=wangjia@ultrarisc.com \
--cc=zhangxincheng@ultrarisc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox