* Re: [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node
2026-04-20 13:18 [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node Jai Luthra
@ 2026-04-20 13:38 ` Laurent Pinchart
2026-04-20 15:30 ` Conor Dooley
2026-04-21 0:44 ` 回复: " Changhuang Liang
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2026-04-20 13:38 UTC (permalink / raw)
To: Jai Luthra
Cc: Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Changhuang Liang, Mauro Carvalho Chehab,
Sakari Ailus, Krzysztof Kozlowski, linux-riscv, devicetree,
linux-kernel
Hi Jai,
Thank you for the patch.
On Mon, Apr 20, 2026 at 06:48:07PM +0530, Jai Luthra wrote:
> The starfive-camss driver and bindings were dropped, as they were no
> longer being worked upon for destaging.
>
> Drop the relevant node as well to avoid the following build warning:
> "failed to match any schema with compatible: ['starfive,jh7110-camss']"
>
> Fixes: 644673fc8fb04 ("media: dt-bindings: Drop starfive,jh7110-camss from staging")
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes: https://lore.kernel.org/all/20260420-very-cartel-645595ffd1c7@spud/
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Assuming you've run the DT checks,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Ideally this patch should have gone in the original series, before the
> one that dropped the bindings which is now merged in mainline.
>
> I've added a Fixes tag so it gets picked in the RC cycles for 7.1.
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 27 +-----------------------
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 -------------------------
> 2 files changed, 1 insertion(+), 54 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 8cfe8033305d80cbe6179ed26601ca057ee00f16..a7a1c09a2c9075711f3a214a49618911fdc7b421 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -135,29 +135,6 @@ &tdm_ext {
> clock-frequency = <49152000>;
> };
>
> -&camss {
> - assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
> - <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
> - assigned-clock-rates = <49500000>, <198000000>;
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> - };
> -
> - port@1 {
> - reg = <1>;
> -
> - camss_from_csi2rx: endpoint {
> - remote-endpoint = <&csi2rx_to_camss>;
> - };
> - };
> - };
> -};
> -
> &csi2rx {
> assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
> assigned-clock-rates = <297000000>;
> @@ -175,9 +152,7 @@ port@0 {
> port@1 {
> reg = <1>;
>
> - csi2rx_to_camss: endpoint {
> - remote-endpoint = <&camss_from_csi2rx>;
> - };
> + /* remote CAMSS endpoint */
> };
> };
> };
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index 6e56e9d20bb064e86b57a92d4cb05be330cca01a..9c3e4598747eb5541effe697044484715569a285 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -1199,34 +1199,6 @@ csi_phy: phy@19820000 {
> #phy-cells = <0>;
> };
>
> - camss: isp@19840000 {
> - compatible = "starfive,jh7110-camss";
> - reg = <0x0 0x19840000 0x0 0x10000>,
> - <0x0 0x19870000 0x0 0x30000>;
> - reg-names = "syscon", "isp";
> - clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
> - <&ispcrg JH7110_ISPCLK_ISPV2_TOP_WRAPPER_C>,
> - <&ispcrg JH7110_ISPCLK_DVP_INV>,
> - <&ispcrg JH7110_ISPCLK_VIN_P_AXI_WR>,
> - <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>,
> - <&syscrg JH7110_SYSCLK_ISP_TOP_CORE>,
> - <&syscrg JH7110_SYSCLK_ISP_TOP_AXI>;
> - clock-names = "apb_func", "wrapper_clk_c", "dvp_inv",
> - "axiwr", "mipi_rx0_pxl", "ispcore_2x",
> - "isp_axi";
> - resets = <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_P>,
> - <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_C>,
> - <&ispcrg JH7110_ISPRST_VIN_P_AXI_RD>,
> - <&ispcrg JH7110_ISPRST_VIN_P_AXI_WR>,
> - <&syscrg JH7110_SYSRST_ISP_TOP>,
> - <&syscrg JH7110_SYSRST_ISP_TOP_AXI>;
> - reset-names = "wrapper_p", "wrapper_c", "axird",
> - "axiwr", "isp_top_n", "isp_top_axi";
> - power-domains = <&pwrc JH7110_PD_ISP>;
> - interrupts = <92>, <87>, <90>, <88>;
> - status = "disabled";
> - };
> -
> voutcrg: clock-controller@295c0000 {
> compatible = "starfive,jh7110-voutcrg";
> reg = <0x0 0x295c0000 0x0 0x10000>;
>
> ---
> base-commit: c1f49dea2b8f335813d3b348fd39117fb8efb428
> change-id: 20260420-starfive_camss_use-7a229c330e71
--
Regards,
Laurent Pinchart
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node
2026-04-20 13:18 [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node Jai Luthra
2026-04-20 13:38 ` Laurent Pinchart
@ 2026-04-20 15:30 ` Conor Dooley
2026-04-21 0:44 ` 回复: " Changhuang Liang
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-04-20 15:30 UTC (permalink / raw)
To: Jai Luthra
Cc: Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Changhuang Liang, Mauro Carvalho Chehab, Sakari Ailus,
Laurent Pinchart, Krzysztof Kozlowski, linux-riscv, devicetree,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 995 bytes --]
On Mon, Apr 20, 2026 at 06:48:07PM +0530, Jai Luthra wrote:
> The starfive-camss driver and bindings were dropped, as they were no
> longer being worked upon for destaging.
>
> Drop the relevant node as well to avoid the following build warning:
> "failed to match any schema with compatible: ['starfive,jh7110-camss']"
>
> Fixes: 644673fc8fb04 ("media: dt-bindings: Drop starfive,jh7110-camss from staging")
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes: https://lore.kernel.org/all/20260420-very-cartel-645595ffd1c7@spud/
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
> Ideally this patch should have gone in the original series, before the
> one that dropped the bindings which is now merged in mainline.
>
> I've added a Fixes tag so it gets picked in the RC cycles for 7.1.
I don't believe this fixes tag is appropriate, so I will drop it on
application. Doesn't really make sense to cite a binding patch as being
the problem with a dts.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread* 回复: [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node
2026-04-20 13:18 [PATCH] riscv: dts: starfive: jh7110: Drop CAMSS node Jai Luthra
2026-04-20 13:38 ` Laurent Pinchart
2026-04-20 15:30 ` Conor Dooley
@ 2026-04-21 0:44 ` Changhuang Liang
2 siblings, 0 replies; 4+ messages in thread
From: Changhuang Liang @ 2026-04-21 0:44 UTC (permalink / raw)
To: Jai Luthra, Emil Renner Berthing, Conor Dooley, Rob Herring,
Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Mauro Carvalho Chehab, Sakari Ailus,
Laurent Pinchart
Cc: Krzysztof Kozlowski, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
> The starfive-camss driver and bindings were dropped, as they were no longer
> being worked upon for destaging.
>
> Drop the relevant node as well to avoid the following build warning:
> "failed to match any schema with compatible: ['starfive,jh7110-camss']"
>
> Fixes: 644673fc8fb04 ("media: dt-bindings: Drop starfive,jh7110-camss from
> staging")
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes:
> https://lore.kernel.org/all/20260420-very-cartel-645595ffd1c7@spud/
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Ideally this patch should have gone in the original series, before the one that
> dropped the bindings which is now merged in mainline.
>
> I've added a Fixes tag so it gets picked in the RC cycles for 7.1.
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 27 +-----------------------
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 -------------------------
> 2 files changed, 1 insertion(+), 54 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index
> 8cfe8033305d80cbe6179ed26601ca057ee00f16..a7a1c09a2c9075711f3a214
> a49618911fdc7b421 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -135,29 +135,6 @@ &tdm_ext {
> clock-frequency = <49152000>;
> };
>
> -&camss {
> - assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
> - <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
> - assigned-clock-rates = <49500000>, <198000000>;
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> - };
> -
> - port@1 {
> - reg = <1>;
> -
> - camss_from_csi2rx: endpoint {
> - remote-endpoint = <&csi2rx_to_camss>;
> - };
> - };
> - };
> -};
> -
> &csi2rx {
> assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
> assigned-clock-rates = <297000000>;
> @@ -175,9 +152,7 @@ port@0 {
> port@1 {
> reg = <1>;
>
> - csi2rx_to_camss: endpoint {
> - remote-endpoint = <&camss_from_csi2rx>;
> - };
> + /* remote CAMSS endpoint */
> };
> };
> };
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index
> 6e56e9d20bb064e86b57a92d4cb05be330cca01a..9c3e4598747eb5541effe6
> 97044484715569a285 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -1199,34 +1199,6 @@ csi_phy: phy@19820000 {
> #phy-cells = <0>;
> };
>
> - camss: isp@19840000 {
> - compatible = "starfive,jh7110-camss";
> - reg = <0x0 0x19840000 0x0 0x10000>,
> - <0x0 0x19870000 0x0 0x30000>;
> - reg-names = "syscon", "isp";
> - clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
> - <&ispcrg JH7110_ISPCLK_ISPV2_TOP_WRAPPER_C>,
> - <&ispcrg JH7110_ISPCLK_DVP_INV>,
> - <&ispcrg JH7110_ISPCLK_VIN_P_AXI_WR>,
> - <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>,
> - <&syscrg JH7110_SYSCLK_ISP_TOP_CORE>,
> - <&syscrg JH7110_SYSCLK_ISP_TOP_AXI>;
> - clock-names = "apb_func", "wrapper_clk_c", "dvp_inv",
> - "axiwr", "mipi_rx0_pxl", "ispcore_2x",
> - "isp_axi";
> - resets = <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_P>,
> - <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_C>,
> - <&ispcrg JH7110_ISPRST_VIN_P_AXI_RD>,
> - <&ispcrg JH7110_ISPRST_VIN_P_AXI_WR>,
> - <&syscrg JH7110_SYSRST_ISP_TOP>,
> - <&syscrg JH7110_SYSRST_ISP_TOP_AXI>;
> - reset-names = "wrapper_p", "wrapper_c", "axird",
> - "axiwr", "isp_top_n", "isp_top_axi";
> - power-domains = <&pwrc JH7110_PD_ISP>;
> - interrupts = <92>, <87>, <90>, <88>;
> - status = "disabled";
> - };
> -
> voutcrg: clock-controller@295c0000 {
> compatible = "starfive,jh7110-voutcrg";
> reg = <0x0 0x295c0000 0x0 0x10000>;
>
> ---
> base-commit: c1f49dea2b8f335813d3b348fd39117fb8efb428
> change-id: 20260420-starfive_camss_use-7a229c330e71
>
> Best regards,
> --
> Jai Luthra <jai.luthra@ideasonboard.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread