From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Inochi Amaoto <inochiama@outlook.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string
Date: Fri, 25 Oct 2024 16:44:55 +0200 [thread overview]
Message-ID: <2b691bea-3b2a-469b-bf5f-5e80b9b9b9a8@intel.com> (raw)
In-Reply-To: <20241025011000.244350-4-inochiama@gmail.com>
From: Inochi Amaoto <inochiama@gmail.com>
Date: Fri, 25 Oct 2024 09:09:59 +0800
> Add "snps,dwmac-5.30a" compatible string for 5.30a version that can avoid
> to define some platform data in the glue layer.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index ad868e8d195d..3c4e78b10dd6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -555,7 +555,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
> of_device_is_compatible(np, "snps,dwmac-4.10a") ||
> of_device_is_compatible(np, "snps,dwmac-4.20a") ||
> of_device_is_compatible(np, "snps,dwmac-5.10a") ||
> - of_device_is_compatible(np, "snps,dwmac-5.20")) {
> + of_device_is_compatible(np, "snps,dwmac-5.20") ||
> + of_device_is_compatible(np, "snps,dwmac-5.30a")) {
Please convert this to a const char * const [] table with all these
strings + one of_device_compatible_match().
> plat->has_gmac4 = 1;
> plat->has_gmac = 0;
> plat->pmt = 1;
Thanks,
Olek
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-10-25 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 1:09 [PATCH v2 0/4] riscv: sophgo: Add ethernet support for SG2044 Inochi Amaoto
2024-10-25 1:09 ` [PATCH v2 1/4] dt-bindings: net: snps,dwmac: Add dwmac-5.30a version Inochi Amaoto
2024-10-27 20:35 ` Krzysztof Kozlowski
2024-10-25 1:09 ` [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac Inochi Amaoto
2024-10-27 20:38 ` Krzysztof Kozlowski
2024-10-27 23:32 ` Inochi Amaoto
2024-10-28 7:06 ` Krzysztof Kozlowski
2024-10-28 7:16 ` Inochi Amaoto
2024-10-29 13:27 ` Krzysztof Kozlowski
2024-10-30 0:43 ` Inochi Amaoto
2024-10-25 1:09 ` [PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string Inochi Amaoto
2024-10-25 14:44 ` Alexander Lobakin [this message]
2024-10-25 23:32 ` Inochi Amaoto
2024-10-25 1:10 ` [PATCH v2 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC Inochi Amaoto
2024-10-25 14:36 ` kernel test robot
2024-10-25 14:53 ` Alexander Lobakin
2024-10-25 23:27 ` Inochi Amaoto
2024-10-25 15:48 ` kernel test robot
2024-10-25 19:34 ` kernel test robot
2024-10-25 13:08 ` [PATCH v2 0/4] riscv: sophgo: Add ethernet support for SG2044 Simon Horman
2024-10-25 23:24 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b691bea-3b2a-469b-bf5f-5e80b9b9b9a8@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=inochiama@outlook.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=looong.bin@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox