Re: [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Inochi Amaoto <inochiama@outlook.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac
Date: Tue, 29 Oct 2024 14:27:20 +0100	[thread overview]
Message-ID: <e134b98f-5a57-4a37-b46b-8b4017f050a6@kernel.org> (raw)
In-Reply-To: <gcur4pgotkwp6nd557ftkvlzh5xv3shxvvl3ofictlie2hlxua@f4zxljrgzvke>

On 28/10/2024 08:16, Inochi Amaoto wrote:
> On Mon, Oct 28, 2024 at 08:06:25AM +0100, Krzysztof Kozlowski wrote:
>> On 28/10/2024 00:32, Inochi Amaoto wrote:
>>> On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote:
>>>> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote:
>>>>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC
>>>>> with some extra clock.
>>>>>
>>>>> Add necessary compatible string for this device.
>>>>>
>>>>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>>>>> ---
>>>>
>>>> This should be squashed with a corrected previous patch 
>>>
>>> Good, I will.
>>>
>>>> (why do you need to select snps,dwmac-5.30a?), 
>>>
>>> The is because the driver use the fallback versioned compatible 
>>> string to set up some common arguments. (This is what the patch
>>
>> Nope. Driver never relies on schema doing select. That's just incorrect.
>>
> 
> Yeah, I make a mistake on understanding you. For me, I just followed
> what others do. But there is a comment before this select.
> 
> """
> Select every compatible, including the deprecated ones. This way, we
> will be able to report a warning when we have that compatible, since
> we will validate the node thanks to the select, but won't report it
> as a valid value in the compatible property description
> """
> 
> By reading this, I think there may be some historical reason? Maybe
> someone can explain this.

I think this is left-over from older times before all specific
compatibles were added here and in their bindings. This binding has been
waiting for some cleanup for a while now, so this is fine.

I still think the patches should be merged, though.

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv