Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	 Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: defconfig: enable NLS_ISO8859_1
Date: Wed, 14 Jan 2026 17:19:57 -0700 (MST)	[thread overview]
Message-ID: <345da49c-b8b5-8538-6231-c614792c9092@kernel.org> (raw)
In-Reply-To: <20260111-nls_iso8859_1_y_riscv-v1-1-2c992bb2c00d@gmail.com>

On Sun, 11 Jan 2026, Javier Carrasco wrote:

> NLS_ISO8859_1 was enabled as a module with commit efe1e08bca9a ("riscv:
> defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1"), but the
> NLS_CODEPAGE_437 counterpart is selected as built-in. The commit does
> not explain the reason behind, and it is not consistent with the
> defconfig for ARM64 that also enables these modules to mount EFI system
> partitions.
> 
> Select NLS_ISO8859_1 as built-in to provide both requirements within the
> kernel image.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> I stumbled upon this while scripting commands to launch
> qemu-system-aarch64 and qemu-system-riscv64 with debian no-cloud images
> and -kernel to provide a defconfig kernel in both cases. I expected the
> same behavior to mount the EFI partition, but it failed for riscv unless
> the modules were installed/provided. That didn't happen for arm64 as
> NLS_ISO8859_1 is built-in.
> 
> If there are no good reasons to keep these configurations differently
> for these architectures and only have NLS_CODEPAGE_437 bult-in, having
> NLS_ISO8859_1 built-in is more consistent and the EFI partitions are
> mounted more easily. This is the only configuration that had to be
> modified to boot Debian 12 and 13.

Thanks, queued for v6.20.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2026-01-15  0:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11  7:16 [PATCH] riscv: defconfig: enable NLS_ISO8859_1 Javier Carrasco
2026-01-15  0:19 ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=345da49c-b8b5-8538-6231-c614792c9092@kernel.org \
    --to=pjw@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox