Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] riscv: defconfig: enable NLS_ISO8859_1
@ 2026-01-11  7:16 Javier Carrasco
  2026-01-15  0:19 ` Paul Walmsley
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Carrasco @ 2026-01-11  7:16 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Heinrich Schuchardt
  Cc: linux-riscv, linux-kernel, Javier Carrasco

NLS_ISO8859_1 was enabled as a module with commit efe1e08bca9a ("riscv:
defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1"), but the
NLS_CODEPAGE_437 counterpart is selected as built-in. The commit does
not explain the reason behind, and it is not consistent with the
defconfig for ARM64 that also enables these modules to mount EFI system
partitions.

Select NLS_ISO8859_1 as built-in to provide both requirements within the
kernel image.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
I stumbled upon this while scripting commands to launch
qemu-system-aarch64 and qemu-system-riscv64 with debian no-cloud images
and -kernel to provide a defconfig kernel in both cases. I expected the
same behavior to mount the EFI partition, but it failed for riscv unless
the modules were installed/provided. That didn't happen for arm64 as
NLS_ISO8859_1 is built-in.

If there are no good reasons to keep these configurations differently
for these architectures and only have NLS_CODEPAGE_437 bult-in, having
NLS_ISO8859_1 built-in is more consistent and the EFI partitions are
mounted more easily. This is the only configuration that had to be
modified to boot Debian 12 and 13.
---
 arch/riscv/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index cd736a1d657e..5ca534a51809 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -295,7 +295,7 @@ CONFIG_NFS_V4_2=y
 CONFIG_ROOT_NFS=y
 CONFIG_9P_FS=y
 CONFIG_NLS_CODEPAGE_437=y
-CONFIG_NLS_ISO8859_1=m
+CONFIG_NLS_ISO8859_1=y
 CONFIG_SECURITY=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_APPARMOR=y

---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20260111-nls_iso8859_1_y_riscv-6e8f262cc7da

Best regards,
--  
Javier Carrasco <javier.carrasco.cruz@gmail.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] riscv: defconfig: enable NLS_ISO8859_1
  2026-01-11  7:16 [PATCH] riscv: defconfig: enable NLS_ISO8859_1 Javier Carrasco
@ 2026-01-15  0:19 ` Paul Walmsley
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Walmsley @ 2026-01-15  0:19 UTC (permalink / raw)
  To: Javier Carrasco
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Heinrich Schuchardt, linux-riscv, linux-kernel

On Sun, 11 Jan 2026, Javier Carrasco wrote:

> NLS_ISO8859_1 was enabled as a module with commit efe1e08bca9a ("riscv:
> defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1"), but the
> NLS_CODEPAGE_437 counterpart is selected as built-in. The commit does
> not explain the reason behind, and it is not consistent with the
> defconfig for ARM64 that also enables these modules to mount EFI system
> partitions.
> 
> Select NLS_ISO8859_1 as built-in to provide both requirements within the
> kernel image.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> I stumbled upon this while scripting commands to launch
> qemu-system-aarch64 and qemu-system-riscv64 with debian no-cloud images
> and -kernel to provide a defconfig kernel in both cases. I expected the
> same behavior to mount the EFI partition, but it failed for riscv unless
> the modules were installed/provided. That didn't happen for arm64 as
> NLS_ISO8859_1 is built-in.
> 
> If there are no good reasons to keep these configurations differently
> for these architectures and only have NLS_CODEPAGE_437 bult-in, having
> NLS_ISO8859_1 built-in is more consistent and the EFI partitions are
> mounted more easily. This is the only configuration that had to be
> modified to boot Debian 12 and 13.

Thanks, queued for v6.20.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-15  0:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-11  7:16 [PATCH] riscv: defconfig: enable NLS_ISO8859_1 Javier Carrasco
2026-01-15  0:19 ` Paul Walmsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox