From: <Conor.Dooley@microchip.com>
To: <Damien.LeMoal@wdc.com>, <robh+dt@kernel.org>,
<jassisinghbrar@gmail.com>, <aou@eecs.berkeley.edu>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<devicetree@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Cc: Cyril.Jean@microchip.com, david.abdurachmanov@gmail.com,
Daire.McNamara@microchip.com, Anup.Patel@wdc.com,
Atish.Patra@wdc.com, Lewis.Hanly@microchip.com
Subject: Re: [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox
Date: Tue, 1 Dec 2020 15:54:30 +0000 [thread overview]
Message-ID: <68f64366-bcc9-df51-1061-dc8b7adf5ddf@microchip.com> (raw)
In-Reply-To: <CH2PR04MB6522B0B3F824BFB01EE0C635E7F40@CH2PR04MB6522.namprd04.prod.outlook.com>
On 01/12/2020 11:55, Damien Le Moal wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 2020/12/01 20:02, conor.dooley@microchip.com wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> This driver adds support for the single mailbox channel of the MSS
>> system controller on the Microchip PolarFire SoC.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> drivers/mailbox/Kconfig | 12 ++
>> drivers/mailbox/Makefile | 2 +
>> drivers/mailbox/mailbox-mpfs.c | 285 +++++++++++++++++++++++++++++++++
>> include/soc/microchip/mpfs.h | 51 ++++++
>> 4 files changed, 350 insertions(+)
>> create mode 100644 drivers/mailbox/mailbox-mpfs.c
>> create mode 100644 include/soc/microchip/mpfs.h
(trimmed)
>> diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c
>> new file mode 100644
>> index 000000000000..e1ecf3081312
>> --- /dev/null
>> +++ b/drivers/mailbox/mailbox-mpfs.c
>> @@ -0,0 +1,285 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Microchip MPFS system controller/mailbox controller driver
>> + *
>> + * Copyright (c) 2020 Microchip Corporation. All rights reserved.
>> + *
>> + * Author: Conor Dooley <conor.dooley@microchip.com>
>> + *
>> + */
>> +
>> +#include <linux/io.h>
>> +#include <linux/err.h>
>> +#include <linux/init.h>
>> +#include <linux/module.h>
>> +#include <linux/kernel.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/mailbox_controller.h>
>> +#include <soc/microchip/mpfs.h>
>> +
>> +#define SERVICES_CR_OFFSET 0x50u
>> +#define SERVICES_SR_OFFSET 0x54u
>> +#define MAILBOX_REG_OFFSET 0x800u
>> +#define MSS_SYS_BUSY -EBUSY
>> +#define MSS_SYS_PARAM_ERR -EINVAL
>> +#define MSS_SYS_MAILBOX_DATA_OFFSET 0u
>> +#define SCB_MASK_WIDTH 16u
> Value identation seems off here. Aligning it would be nice.
Not really sure why thats off, its off in my mail client too but it's aligned when I apply the patch from the original text file, or if I git am the emailed patch.
I'll address the other comments in the next version.
> --
> Damien Le Moal
> Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-12-01 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:02 [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox conor.dooley
2020-12-01 11:55 ` Damien Le Moal
2020-12-01 15:54 ` Conor.Dooley [this message]
2020-12-01 14:13 ` Jonathan Neuschäfer
2020-12-01 16:26 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f64366-bcc9-df51-1061-dc8b7adf5ddf@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=Cyril.Jean@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Lewis.Hanly@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox