From: <Conor.Dooley@microchip.com>
To: <j.neuschaefer@gmx.net>
Cc: devicetree@vger.kernel.org, damien.lemoal@wdc.com,
aou@eecs.berkeley.edu, Cyril.Jean@microchip.com,
david.abdurachmanov@gmail.com, Daire.McNamara@microchip.com,
jassisinghbrar@gmail.com, atish.patra@wdc.com,
anup.patel@wdc.com, robh+dt@kernel.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, Lewis.Hanly@microchip.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox
Date: Tue, 1 Dec 2020 16:26:40 +0000 [thread overview]
Message-ID: <f5683df4-8e90-7d39-189a-0f7faf1d899e@microchip.com> (raw)
In-Reply-To: <20201201141328.GJ456020@latitude>
On 01/12/2020 14:13, Jonathan Neuschäfer wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Tue, Dec 01, 2020 at 11:02:42AM +0000, conor.dooley@microchip.com wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > This driver adds support for the single mailbox channel of the MSS
> > system controller on the Microchip PolarFire SoC.
>
> Out of my curiosity: What is MSS? Is it the Microprocessor Subsystem in
> the SoC?
>
yes, it is the microprocessor subsystem
> (It isn't quite clear from the PolarFire documentation I could find)
>
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> [...]
> > +config MPFS_MBOX
> > + tristate "MPFS Mailbox"
>
> "MPFS" in the title seems (to me) a bit too obscure for the uninitiated.
> Perhaps you could use something slightly longer that mentions Microchip
> and/or the PolarFire series?
Sure. MPFS is the part name while PolarFire SoC is the marketing name.
I will switch it in the next version to POLARFIRE_SOC_MBOX, which better matches
the config option for the SoC directory that's in Atish's patches anyway.
> > +++ b/drivers/mailbox/mailbox-mpfs.c
> > @@ -0,0 +1,285 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Microchip MPFS system controller/mailbox controller driver
>
> The same might apply here.
>
>
> Best regards,
> Jonathan Neuschäfer
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-12-01 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:02 [PATCH v2 1/5] mbox: add polarfire soc system controller mailbox conor.dooley
2020-12-01 11:55 ` Damien Le Moal
2020-12-01 15:54 ` Conor.Dooley
2020-12-01 14:13 ` Jonathan Neuschäfer
2020-12-01 16:26 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5683df4-8e90-7d39-189a-0f7faf1d899e@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Cyril.Jean@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=jassisinghbrar@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox