Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name
@ 2026-07-30 13:19 Nam Cao
  2026-07-30 14:15 ` Jesse Taube
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Nam Cao @ 2026-07-30 13:19 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Jesse Taube, Anirudh Srinivasan, linux-riscv, linux-kernel
  Cc: Nam Cao, kernel test robot

When CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS=n, the no-op stub for
check_vector_unaligned_access() has the wrong name and causes compile
failure.

Correct the name.

Fixes: f54d193db5da ("riscv: unaligned: stop using kthread for check_vector_unaligned_access()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607301618.yrE3EKfS-lkp@intel.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
---
This patch can also be squashed to f54d193db5da.
---
 arch/riscv/kernel/unaligned_access_speed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c
index 5212aa99771e..6e35bca568de 100644
--- a/arch/riscv/kernel/unaligned_access_speed.c
+++ b/arch/riscv/kernel/unaligned_access_speed.c
@@ -288,7 +288,7 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus
 }
 
 #else /* CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS */
-static void check_unaligned_access_speed(struct work_struct *work __always_unused)
+static void check_vector_unaligned_access(struct work_struct *work __always_unused)
 {
 }
 #endif
-- 
2.47.3


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name
  2026-07-30 13:19 [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name Nam Cao
@ 2026-07-30 14:15 ` Jesse Taube
  2026-07-31  3:30 ` Nutty.Liu
  2026-08-04  0:05 ` Paul Walmsley
  2 siblings, 0 replies; 4+ messages in thread
From: Jesse Taube @ 2026-07-30 14:15 UTC (permalink / raw)
  To: Nam Cao
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Anirudh Srinivasan, linux-riscv, linux-kernel, kernel test robot

On Thu, Jul 30, 2026 at 9:19 AM Nam Cao <namcao@linutronix.de> wrote:
>
> When CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS=n, the no-op stub for
> check_vector_unaligned_access() has the wrong name and causes compile
> failure.
>
> Correct the name.
>
> Fixes: f54d193db5da ("riscv: unaligned: stop using kthread for check_vector_unaligned_access()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202607301618.yrE3EKfS-lkp@intel.com/
> Signed-off-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Jesse Taube <jtaubepe@redhat.com>

> ---
> This patch can also be squashed to f54d193db5da.
Agreed

Thanks,
Jesse Taube

> ---
>  arch/riscv/kernel/unaligned_access_speed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c
> index 5212aa99771e..6e35bca568de 100644
> --- a/arch/riscv/kernel/unaligned_access_speed.c
> +++ b/arch/riscv/kernel/unaligned_access_speed.c
> @@ -288,7 +288,7 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus
>  }
>
>  #else /* CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS */
> -static void check_unaligned_access_speed(struct work_struct *work __always_unused)
> +static void check_vector_unaligned_access(struct work_struct *work __always_unused)
>  {
>  }
>  #endif
> --
> 2.47.3
>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name
  2026-07-30 13:19 [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name Nam Cao
  2026-07-30 14:15 ` Jesse Taube
@ 2026-07-31  3:30 ` Nutty.Liu
  2026-08-04  0:05 ` Paul Walmsley
  2 siblings, 0 replies; 4+ messages in thread
From: Nutty.Liu @ 2026-07-31  3:30 UTC (permalink / raw)
  To: Nam Cao, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti, Jesse Taube, Anirudh Srinivasan, linux-riscv,
	linux-kernel
  Cc: kernel test robot


On 7/30/2026 9:19 PM, Nam Cao wrote:
> When CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS=n, the no-op stub for
> check_vector_unaligned_access() has the wrong name and causes compile
> failure.
>
> Correct the name.
>
> Fixes: f54d193db5da ("riscv: unaligned: stop using kthread for check_vector_unaligned_access()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202607301618.yrE3EKfS-lkp@intel.com/
> Signed-off-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Nutty Liu <nutty.liu@hotmail.com>

Thanks,
Nutty
> ---
> This patch can also be squashed to f54d193db5da.
> ---
>   arch/riscv/kernel/unaligned_access_speed.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c
> index 5212aa99771e..6e35bca568de 100644
> --- a/arch/riscv/kernel/unaligned_access_speed.c
> +++ b/arch/riscv/kernel/unaligned_access_speed.c
> @@ -288,7 +288,7 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus
>   }
>   
>   #else /* CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS */
> -static void check_unaligned_access_speed(struct work_struct *work __always_unused)
> +static void check_vector_unaligned_access(struct work_struct *work __always_unused)
>   {
>   }
>   #endif

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name
  2026-07-30 13:19 [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name Nam Cao
  2026-07-30 14:15 ` Jesse Taube
  2026-07-31  3:30 ` Nutty.Liu
@ 2026-08-04  0:05 ` Paul Walmsley
  2 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2026-08-04  0:05 UTC (permalink / raw)
  To: Nam Cao
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Jesse Taube, Anirudh Srinivasan, linux-riscv, linux-kernel,
	kernel test robot

On Thu, 30 Jul 2026, Nam Cao wrote:

> When CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS=n, the no-op stub for
> check_vector_unaligned_access() has the wrong name and causes compile
> failure.
> 
> Correct the name.

Thanks, looks like I broke this during conflict resolution.  Sorry about 
that.  I squashed the fix into the original as you suggested.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-08-04  0:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 13:19 [PATCH] riscv: unaligned: Fix check_vector_unaligned_access() stub name Nam Cao
2026-07-30 14:15 ` Jesse Taube
2026-07-31  3:30 ` Nutty.Liu
2026-08-04  0:05 ` Paul Walmsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox