Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: mick@ics.forth.gr (Nick Kossifidis)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] RISC-V: Cosmetic menuconfig changes
Date: Sat, 29 Sep 2018 23:45:05 +0300	[thread overview]
Message-ID: <904aad36ec736345fc715b3f13c268f1@mailhost.ics.forth.gr> (raw)
In-Reply-To: <mhng-4c7f23e6-3111-4b77-9cb9-87da815f14d7@palmer-si-x1c4>

???? 2018-09-29 04:44, Palmer Dabbelt ??????:
> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick at ics.forth.gr wrote:
>> * Move the built-in cmdline configuration on a new menu entry "Boot
>>   options", it doesn't make much sense to be part of the debuging 
>> menu.
>> 
>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent 
>> with
>>   what other architectures are using, plus "type" is a bit misleading 
>> here.
>> 
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> 
> This seems reasonable to me.  I've added it to our for-next branch,
> we'll see if anyone else has comments.  Thanks!
> 
> Did you, by any chance, go and check to see if these boot options
> actually work?  We've got a bunch of subtly different boot methods and
> they've been broken in various ones at various times, so I always like
> to try and catalog what actually works now so at least I know where to
> look when testing things.
> 

I assumed that since it was already there it worked but you are right, 
cmdline when passed from the bootloader through the generated device 
tree 
(https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c) 
works but when passed through the config option doesn't. Do you want me 
to send a separate patch for that or re-send this one as well as a 
series ?

WARNING: multiple messages have this Message-ID (diff)
From: Nick Kossifidis <mick@ics.forth.gr>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: mick@ics.forth.gr, linux-riscv@lists.infradead.org,
	aou@eecs.berkeley.edu
Subject: Re: [PATCH] RISC-V: Cosmetic menuconfig changes
Date: Sat, 29 Sep 2018 23:45:05 +0300	[thread overview]
Message-ID: <904aad36ec736345fc715b3f13c268f1@mailhost.ics.forth.gr> (raw)
Message-ID: <20180929204505.UHVolnNJAIJfg0_VzmDyz0hWJRUq4_zTUEZkoM2qnOo@z> (raw)
In-Reply-To: <mhng-4c7f23e6-3111-4b77-9cb9-87da815f14d7@palmer-si-x1c4>

Στις 2018-09-29 04:44, Palmer Dabbelt έγραψε:
> On Wed, 19 Sep 2018 15:48:15 PDT (-0700), mick@ics.forth.gr wrote:
>> * Move the built-in cmdline configuration on a new menu entry "Boot
>>   options", it doesn't make much sense to be part of the debuging 
>> menu.
>> 
>> * Rename "Kernel Type" menu to "Kernel features" to be more consistent 
>> with
>>   what other architectures are using, plus "type" is a bit misleading 
>> here.
>> 
>> Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
> 
> This seems reasonable to me.  I've added it to our for-next branch,
> we'll see if anyone else has comments.  Thanks!
> 
> Did you, by any chance, go and check to see if these boot options
> actually work?  We've got a bunch of subtly different boot methods and
> they've been broken in various ones at various times, so I always like
> to try and catalog what actually works now so at least I know where to
> look when testing things.
> 

I assumed that since it was already there it worked but you are right, 
cmdline when passed from the bootloader through the generated device 
tree 
(https://github.com/riscv/riscv-qemu/blob/riscv-all/hw/riscv/virt.c) 
works but when passed through the config option doesn't. Do you want me 
to send a separate patch for that or re-send this one as well as a 
series ?

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2018-09-29 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 22:48 [PATCH] RISC-V: Cosmetic menuconfig changes Nick Kossifidis
2018-09-29  1:44 ` Palmer Dabbelt
2018-09-29  1:44   ` Palmer Dabbelt
2018-09-29 20:45   ` Nick Kossifidis [this message]
2018-09-29 20:45     ` Nick Kossifidis
2018-10-01 16:56     ` Palmer Dabbelt
2018-10-01 16:56       ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=904aad36ec736345fc715b3f13c268f1@mailhost.ics.forth.gr \
    --to=mick@ics.forth.gr \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox