From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Alex Elder <elder@riscstar.com>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@gentoo.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent
Date: Mon, 29 Dec 2025 09:20:57 +0800 [thread overview]
Message-ID: <E42FFF2530F73556+aVHXeY6PlQt40uY1@kernel.org> (raw)
In-Reply-To: <b09d6add-40d8-4deb-b63e-31adc9f327b1@riscstar.com>
On Sun, Dec 28, 2025 at 06:56:38PM -0600, Alex Elder wrote:
> On 12/26/25 2:32 AM, Troy Mitchell wrote:
> > The clock-frequency property is optional according to the DT binding.
> > Do not emit a warning when the property is missing and fall back to the
> > default frequency instead.
> >
> > Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> > Suggested-by: Alex Elder <elder@riscstar.com>
> > Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
>
> Any error reading the "clock-frequency" property will simply leave
> i2c->clock_freq alone. This is good.
>
> But the lines that follow this issue a warning if i2c->clock_freq
> is 0. If it's optional, you should simply use a default value,
> and although you could state that rate with dev_info(), you should
> not warn about it.
Thanks! I get your point!
- Troy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-12-29 1:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 8:31 [PATCH v5 0/3] i2c: spacemit: improve clock handling and cleanups Troy Mitchell
2025-12-26 8:31 ` [PATCH v5 1/3] i2c: spacemit: drop useless spaces Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2026-01-14 23:11 ` Andi Shyti
2025-12-26 8:32 ` [PATCH v5 2/3] i2c: spacemit: configure ILCR for accurate SCL frequency Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2025-12-29 1:47 ` Troy Mitchell
2025-12-26 8:32 ` [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2025-12-29 1:20 ` Troy Mitchell [this message]
2026-01-14 23:04 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E42FFF2530F73556+aVHXeY6PlQt40uY1@kernel.org \
--to=troy.mitchell@linux.spacemit.com \
--cc=andi.shyti@kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox