From: Andi Shyti <andi.shyti@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Yixun Lan <dlan@gentoo.org>, Alex Elder <elder@riscstar.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v5 1/3] i2c: spacemit: drop useless spaces
Date: Thu, 15 Jan 2026 00:11:57 +0100 [thread overview]
Message-ID: <aWgiV4E-KtVG3uDl@zenone.zhora.eu> (raw)
In-Reply-To: <20251226-k1-i2c-ilcr-v5-1-b5807b7dd0e6@linux.spacemit.com>
Hi Troy,
On Fri, Dec 26, 2025 at 04:31:59PM +0800, Troy Mitchell wrote:
> Previously, the I2C driver had an extra leading space in column 0 of
> included header lines. This commit removes the redundant whitespace.
>
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
I merged just this patch to i2c/i2c-host so that you don't need
to carry it around.
> - #include <linux/clk.h>
> - #include <linux/i2c.h>
> - #include <linux/iopoll.h>
> - #include <linux/module.h>
> - #include <linux/of_address.h>
> - #include <linux/platform_device.h>
There was a little conflict here which was easy to fix because
linux/reset.h has been included in the meantime.
Thanks,
Andi
> +#include <linux/clk.h>
> +#include <linux/i2c.h>
> +#include <linux/iopoll.h>
> +#include <linux/module.h>
> +#include <linux/of_address.h>
> +#include <linux/platform_device.h>
>
> /* spacemit i2c registers */
> #define SPACEMIT_ICR 0x0 /* Control register */
>
> --
> 2.52.0
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-14 23:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 8:31 [PATCH v5 0/3] i2c: spacemit: improve clock handling and cleanups Troy Mitchell
2025-12-26 8:31 ` [PATCH v5 1/3] i2c: spacemit: drop useless spaces Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2026-01-14 23:11 ` Andi Shyti [this message]
2025-12-26 8:32 ` [PATCH v5 2/3] i2c: spacemit: configure ILCR for accurate SCL frequency Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2025-12-29 1:47 ` Troy Mitchell
2025-12-26 8:32 ` [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent Troy Mitchell
2025-12-29 0:56 ` Alex Elder
2025-12-29 1:20 ` Troy Mitchell
2026-01-14 23:04 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWgiV4E-KtVG3uDl@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox