* [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
@ 2023-02-09 3:13 Qinglin Pan
2023-02-09 4:00 ` Qinglin Pan
0 siblings, 1 reply; 8+ messages in thread
From: Qinglin Pan @ 2023-02-09 3:13 UTC (permalink / raw)
To: palmer, linux-riscv; +Cc: jeff, xuyinan, conor, ajones
Svnapot is a RISC-V extension for marking contiguous 4K pages as a non-4K
page. This patch set is for using Svnapot in hugetlb fs and huge vmap.
This patchset adds a Kconfig item for using Svnapot in
"Platform type"->"SVNAPOT extension support". Its default value is on,
and people can set it off if they don't allow kernel to detect Svnapot
hardware support and leverage it.
Tested on:
- qemu rv64 with "Svnapot support" off and svnapot=true.
- qemu rv64 with "Svnapot support" on and svnapot=true.
- qemu rv64 with "Svnapot support" off and svnapot=false.
- qemu rv64 with "Svnapot support" on and svnapot=false.
Changes in v2:
- detect Svnapot hardware support at boot time.
Changes in v3:
- do linear mapping again if has_svnapot
Changes in v4:
- fix some errors/warns reported by checkpatch.pl, thanks @Conor
Changes in v5:
- modify code according to @Conor and @Heiko
Changes in v6:
- use static key insead of alternative errata
Changes in v7:
- add napot_cont_order for possible more napot order in the future
- remove linear mapping related code from this patchset to another patch
- refactor hugetlb code for svnapot according to thanks @Andrew @Conor
- use tools/testing/selftests/vm/map_hugetlb as hugetlb testing program
- support svnapot in huge vmap on newer for-next branch
Changes in v8:
- fix compilation errors in rv32_defconfig
- insert some lines of whitespace according to @Conor's suggestion
Changes in v9:
- use alternative to avoid using static branches inside heavily used
inline functions
- change napot_cont_mask definition
- post test_vmalloc modification about testing vmalloc_huge
Changes in v10:
- fix some nits caught by @Andrew
- collect Reviewed-by/Acked-by
- add memory leak warning in KConfig text
- replace test_vmalloc patch link with the standard one
Changes in v11:
- add more detailed warning about HUGETLBFS and SVNAPOT in KConfig text
- fix missing reverse-xmas tree
Changes in v12:
- rebase on the new ISA extension API [1]
[1]https://lore.kernel.org/all/20230128172856.3814-5-jszhang@kernel.org/
Qinglin Pan (3):
riscv: mm: modify pte format for Svnapot
riscv: mm: support Svnapot in hugetlb page
riscv: mm: support Svnapot in huge vmap
arch/riscv/Kconfig | 21 +-
arch/riscv/include/asm/hugetlb.h | 34 +++-
arch/riscv/include/asm/hwcap.h | 9 +-
arch/riscv/include/asm/page.h | 5 -
arch/riscv/include/asm/pgtable-64.h | 34 ++++
arch/riscv/include/asm/pgtable.h | 39 +++-
arch/riscv/include/asm/vmalloc.h | 61 +++++-
arch/riscv/kernel/cpu.c | 1 +
arch/riscv/kernel/cpufeature.c | 1 +
arch/riscv/mm/hugetlbpage.c | 301 ++++++++++++++++++++++++++++
10 files changed, 493 insertions(+), 13 deletions(-)
--
2.39.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
@ 2023-02-09 3:53 Qinglin Pan
0 siblings, 0 replies; 8+ messages in thread
From: Qinglin Pan @ 2023-02-09 3:53 UTC (permalink / raw)
To: palmer, linux-riscv; +Cc: jeff, xuyinan, conor, ajones, Qinglin Pan
Svnapot is a RISC-V extension for marking contiguous 4K pages as a non-4K
page. This patch set is for using Svnapot in hugetlb fs and huge vmap.
This patchset adds a Kconfig item for using Svnapot in
"Platform type"->"SVNAPOT extension support". Its default value is on,
and people can set it off if they don't allow kernel to detect Svnapot
hardware support and leverage it.
Tested on:
- qemu rv64 with "Svnapot support" off and svnapot=true.
- qemu rv64 with "Svnapot support" on and svnapot=true.
- qemu rv64 with "Svnapot support" off and svnapot=false.
- qemu rv64 with "Svnapot support" on and svnapot=false.
Changes in v2:
- detect Svnapot hardware support at boot time.
Changes in v3:
- do linear mapping again if has_svnapot
Changes in v4:
- fix some errors/warns reported by checkpatch.pl, thanks @Conor
Changes in v5:
- modify code according to @Conor and @Heiko
Changes in v6:
- use static key insead of alternative errata
Changes in v7:
- add napot_cont_order for possible more napot order in the future
- remove linear mapping related code from this patchset to another patch
- refactor hugetlb code for svnapot according to thanks @Andrew @Conor
- use tools/testing/selftests/vm/map_hugetlb as hugetlb testing program
- support svnapot in huge vmap on newer for-next branch
Changes in v8:
- fix compilation errors in rv32_defconfig
- insert some lines of whitespace according to @Conor's suggestion
Changes in v9:
- use alternative to avoid using static branches inside heavily used
inline functions
- change napot_cont_mask definition
- post test_vmalloc modification about testing vmalloc_huge
Changes in v10:
- fix some nits caught by @Andrew
- collect Reviewed-by/Acked-by
- add memory leak warning in KConfig text
- replace test_vmalloc patch link with the standard one
Changes in v11:
- add more detailed warning about HUGETLBFS and SVNAPOT in KConfig text
- fix missing reverse-xmas tree
Changes in v12:
- rebase on the new ISA extension API [1]
[1]https://lore.kernel.org/all/20230128172856.3814-5-jszhang@kernel.org/
Qinglin Pan (3):
riscv: mm: modify pte format for Svnapot
riscv: mm: support Svnapot in hugetlb page
riscv: mm: support Svnapot in huge vmap
arch/riscv/Kconfig | 21 +-
arch/riscv/include/asm/hugetlb.h | 34 +++-
arch/riscv/include/asm/hwcap.h | 9 +-
arch/riscv/include/asm/page.h | 5 -
arch/riscv/include/asm/pgtable-64.h | 34 ++++
arch/riscv/include/asm/pgtable.h | 39 +++-
arch/riscv/include/asm/vmalloc.h | 61 +++++-
arch/riscv/kernel/cpu.c | 1 +
arch/riscv/kernel/cpufeature.c | 1 +
arch/riscv/mm/hugetlbpage.c | 301 ++++++++++++++++++++++++++++
10 files changed, 493 insertions(+), 13 deletions(-)
--
2.39.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 3:13 [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime Qinglin Pan
@ 2023-02-09 4:00 ` Qinglin Pan
2023-02-09 7:30 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Qinglin Pan @ 2023-02-09 4:00 UTC (permalink / raw)
To: linux-riscv
Hi all,
Sorry for bothering :(
This patchset has a bit of a formatting problem.
Please use another one:
https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
Thanks,
Qinglin
On 2023/2/9 11:13, Qinglin Pan wrote:
>
> Svnapot is a RISC-V extension for marking contiguous 4K pages as a non-4K
> page. This patch set is for using Svnapot in hugetlb fs and huge vmap.
>
> This patchset adds a Kconfig item for using Svnapot in
> "Platform type"->"SVNAPOT extension support". Its default value is on,
> and people can set it off if they don't allow kernel to detect Svnapot
> hardware support and leverage it.
>
> Tested on:
> - qemu rv64 with "Svnapot support" off and svnapot=true.
> - qemu rv64 with "Svnapot support" on and svnapot=true.
> - qemu rv64 with "Svnapot support" off and svnapot=false.
> - qemu rv64 with "Svnapot support" on and svnapot=false.
>
>
> Changes in v2:
> - detect Svnapot hardware support at boot time.
> Changes in v3:
> - do linear mapping again if has_svnapot
> Changes in v4:
> - fix some errors/warns reported by checkpatch.pl, thanks @Conor
> Changes in v5:
> - modify code according to @Conor and @Heiko
> Changes in v6:
> - use static key insead of alternative errata
> Changes in v7:
> - add napot_cont_order for possible more napot order in the future
> - remove linear mapping related code from this patchset to another patch
> - refactor hugetlb code for svnapot according to thanks @Andrew @Conor
> - use tools/testing/selftests/vm/map_hugetlb as hugetlb testing program
> - support svnapot in huge vmap on newer for-next branch
> Changes in v8:
> - fix compilation errors in rv32_defconfig
> - insert some lines of whitespace according to @Conor's suggestion
> Changes in v9:
> - use alternative to avoid using static branches inside heavily used
> inline functions
> - change napot_cont_mask definition
> - post test_vmalloc modification about testing vmalloc_huge
> Changes in v10:
> - fix some nits caught by @Andrew
> - collect Reviewed-by/Acked-by
> - add memory leak warning in KConfig text
> - replace test_vmalloc patch link with the standard one
> Changes in v11:
> - add more detailed warning about HUGETLBFS and SVNAPOT in KConfig text
> - fix missing reverse-xmas tree
> Changes in v12:
> - rebase on the new ISA extension API [1]
>
> [1]https://lore.kernel.org/all/20230128172856.3814-5-jszhang@kernel.org/
>
> Qinglin Pan (3):
> riscv: mm: modify pte format for Svnapot
> riscv: mm: support Svnapot in hugetlb page
> riscv: mm: support Svnapot in huge vmap
>
> arch/riscv/Kconfig | 21 +-
> arch/riscv/include/asm/hugetlb.h | 34 +++-
> arch/riscv/include/asm/hwcap.h | 9 +-
> arch/riscv/include/asm/page.h | 5 -
> arch/riscv/include/asm/pgtable-64.h | 34 ++++
> arch/riscv/include/asm/pgtable.h | 39 +++-
> arch/riscv/include/asm/vmalloc.h | 61 +++++-
> arch/riscv/kernel/cpu.c | 1 +
> arch/riscv/kernel/cpufeature.c | 1 +
> arch/riscv/mm/hugetlbpage.c | 301 ++++++++++++++++++++++++++++
> 10 files changed, 493 insertions(+), 13 deletions(-)
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 4:00 ` Qinglin Pan
@ 2023-02-09 7:30 ` Conor Dooley
2023-02-09 8:03 ` Qinglin Pan
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-02-09 7:30 UTC (permalink / raw)
To: Qinglin Pan; +Cc: linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 4310 bytes --]
Hey!
On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
> Hi all,
>
> Sorry for bothering :(
>
> This patchset has a bit of a formatting problem.
> Please use another one:
> https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
If you're resending, please either mark as RESEND or increment the
version number so that tools don't get confused.
In this case though, tools found some issues with both version
unfortunately:
https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
(if you click on the descriptions you should get more information on
what is wrong)
You can fix those up and send a v13 and it'll all be clear then ;)
Cheers,
Conor.
>
> Thanks,
> Qinglin
>
> On 2023/2/9 11:13, Qinglin Pan wrote:
> >
> > Svnapot is a RISC-V extension for marking contiguous 4K pages as a non-4K
> > page. This patch set is for using Svnapot in hugetlb fs and huge vmap.
> >
> > This patchset adds a Kconfig item for using Svnapot in
> > "Platform type"->"SVNAPOT extension support". Its default value is on,
> > and people can set it off if they don't allow kernel to detect Svnapot
> > hardware support and leverage it.
> >
> > Tested on:
> > - qemu rv64 with "Svnapot support" off and svnapot=true.
> > - qemu rv64 with "Svnapot support" on and svnapot=true.
> > - qemu rv64 with "Svnapot support" off and svnapot=false.
> > - qemu rv64 with "Svnapot support" on and svnapot=false.
> >
> >
> > Changes in v2:
> > - detect Svnapot hardware support at boot time.
> > Changes in v3:
> > - do linear mapping again if has_svnapot
> > Changes in v4:
> > - fix some errors/warns reported by checkpatch.pl, thanks @Conor
> > Changes in v5:
> > - modify code according to @Conor and @Heiko
> > Changes in v6:
> > - use static key insead of alternative errata
> > Changes in v7:
> > - add napot_cont_order for possible more napot order in the future
> > - remove linear mapping related code from this patchset to another patch
> > - refactor hugetlb code for svnapot according to thanks @Andrew @Conor
> > - use tools/testing/selftests/vm/map_hugetlb as hugetlb testing program
> > - support svnapot in huge vmap on newer for-next branch
> > Changes in v8:
> > - fix compilation errors in rv32_defconfig
> > - insert some lines of whitespace according to @Conor's suggestion
> > Changes in v9:
> > - use alternative to avoid using static branches inside heavily used
> > inline functions
> > - change napot_cont_mask definition
> > - post test_vmalloc modification about testing vmalloc_huge
> > Changes in v10:
> > - fix some nits caught by @Andrew
> > - collect Reviewed-by/Acked-by
> > - add memory leak warning in KConfig text
> > - replace test_vmalloc patch link with the standard one
> > Changes in v11:
> > - add more detailed warning about HUGETLBFS and SVNAPOT in KConfig text
> > - fix missing reverse-xmas tree
> > Changes in v12:
> > - rebase on the new ISA extension API [1]
> >
> > [1]https://lore.kernel.org/all/20230128172856.3814-5-jszhang@kernel.org/
> >
> > Qinglin Pan (3):
> > riscv: mm: modify pte format for Svnapot
> > riscv: mm: support Svnapot in hugetlb page
> > riscv: mm: support Svnapot in huge vmap
> >
> > arch/riscv/Kconfig | 21 +-
> > arch/riscv/include/asm/hugetlb.h | 34 +++-
> > arch/riscv/include/asm/hwcap.h | 9 +-
> > arch/riscv/include/asm/page.h | 5 -
> > arch/riscv/include/asm/pgtable-64.h | 34 ++++
> > arch/riscv/include/asm/pgtable.h | 39 +++-
> > arch/riscv/include/asm/vmalloc.h | 61 +++++-
> > arch/riscv/kernel/cpu.c | 1 +
> > arch/riscv/kernel/cpufeature.c | 1 +
> > arch/riscv/mm/hugetlbpage.c | 301 ++++++++++++++++++++++++++++
> > 10 files changed, 493 insertions(+), 13 deletions(-)
> >
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 7:30 ` Conor Dooley
@ 2023-02-09 8:03 ` Qinglin Pan
2023-02-09 8:18 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Qinglin Pan @ 2023-02-09 8:03 UTC (permalink / raw)
To: Conor Dooley; +Cc: linux-riscv
Hey!
On 2023/2/9 15:30, Conor Dooley wrote:
> Hey!
>
> On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
>> Hi all,
>>
>> Sorry for bothering :(
>>
>> This patchset has a bit of a formatting problem.
>> Please use another one:
>> https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
>
> If you're resending, please either mark as RESEND or increment the
> version number so that tools don't get confused.
> In this case though, tools found some issues with both version
> unfortunately:
> https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
> https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
> (if you click on the descriptions you should get more information on
> what is wrong)
>
> You can fix those up and send a v13 and it'll all be clear then ;)
Your information is very helpful, thanks so much!
I will send a v13 later. But I am very curious about why
conchuod/alphanumeric_selects is failed and what content is in
this test? Could you please give me some hints about it? ;)
Regards,
Qinglin.
>
> Cheers,
> Conor.
>
>>
>> Thanks,
>> Qinglin
>>
>> On 2023/2/9 11:13, Qinglin Pan wrote:
>>>
>>> Svnapot is a RISC-V extension for marking contiguous 4K pages as a non-4K
>>> page. This patch set is for using Svnapot in hugetlb fs and huge vmap.
>>>
>>> This patchset adds a Kconfig item for using Svnapot in
>>> "Platform type"->"SVNAPOT extension support". Its default value is on,
>>> and people can set it off if they don't allow kernel to detect Svnapot
>>> hardware support and leverage it.
>>>
>>> Tested on:
>>> - qemu rv64 with "Svnapot support" off and svnapot=true.
>>> - qemu rv64 with "Svnapot support" on and svnapot=true.
>>> - qemu rv64 with "Svnapot support" off and svnapot=false.
>>> - qemu rv64 with "Svnapot support" on and svnapot=false.
>>>
>>>
>>> Changes in v2:
>>> - detect Svnapot hardware support at boot time.
>>> Changes in v3:
>>> - do linear mapping again if has_svnapot
>>> Changes in v4:
>>> - fix some errors/warns reported by checkpatch.pl, thanks @Conor
>>> Changes in v5:
>>> - modify code according to @Conor and @Heiko
>>> Changes in v6:
>>> - use static key insead of alternative errata
>>> Changes in v7:
>>> - add napot_cont_order for possible more napot order in the future
>>> - remove linear mapping related code from this patchset to another patch
>>> - refactor hugetlb code for svnapot according to thanks @Andrew @Conor
>>> - use tools/testing/selftests/vm/map_hugetlb as hugetlb testing program
>>> - support svnapot in huge vmap on newer for-next branch
>>> Changes in v8:
>>> - fix compilation errors in rv32_defconfig
>>> - insert some lines of whitespace according to @Conor's suggestion
>>> Changes in v9:
>>> - use alternative to avoid using static branches inside heavily used
>>> inline functions
>>> - change napot_cont_mask definition
>>> - post test_vmalloc modification about testing vmalloc_huge
>>> Changes in v10:
>>> - fix some nits caught by @Andrew
>>> - collect Reviewed-by/Acked-by
>>> - add memory leak warning in KConfig text
>>> - replace test_vmalloc patch link with the standard one
>>> Changes in v11:
>>> - add more detailed warning about HUGETLBFS and SVNAPOT in KConfig text
>>> - fix missing reverse-xmas tree
>>> Changes in v12:
>>> - rebase on the new ISA extension API [1]
>>>
>>> [1]https://lore.kernel.org/all/20230128172856.3814-5-jszhang@kernel.org/
>>>
>>> Qinglin Pan (3):
>>> riscv: mm: modify pte format for Svnapot
>>> riscv: mm: support Svnapot in hugetlb page
>>> riscv: mm: support Svnapot in huge vmap
>>>
>>> arch/riscv/Kconfig | 21 +-
>>> arch/riscv/include/asm/hugetlb.h | 34 +++-
>>> arch/riscv/include/asm/hwcap.h | 9 +-
>>> arch/riscv/include/asm/page.h | 5 -
>>> arch/riscv/include/asm/pgtable-64.h | 34 ++++
>>> arch/riscv/include/asm/pgtable.h | 39 +++-
>>> arch/riscv/include/asm/vmalloc.h | 61 +++++-
>>> arch/riscv/kernel/cpu.c | 1 +
>>> arch/riscv/kernel/cpufeature.c | 1 +
>>> arch/riscv/mm/hugetlbpage.c | 301 ++++++++++++++++++++++++++++
>>> 10 files changed, 493 insertions(+), 13 deletions(-)
>>>
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 8:03 ` Qinglin Pan
@ 2023-02-09 8:18 ` Conor Dooley
2023-02-09 8:40 ` Qinglin Pan
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-02-09 8:18 UTC (permalink / raw)
To: Qinglin Pan; +Cc: linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 2034 bytes --]
On Thu, Feb 09, 2023 at 04:03:01PM +0800, Qinglin Pan wrote:
> Hey!
>
> On 2023/2/9 15:30, Conor Dooley wrote:
> > Hey!
> >
> > On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
> > > Hi all,
> > >
> > > Sorry for bothering :(
> > >
> > > This patchset has a bit of a formatting problem.
> > > Please use another one:
> > > https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
> >
> > If you're resending, please either mark as RESEND or increment the
> > version number so that tools don't get confused.
> > In this case though, tools found some issues with both version
> > unfortunately:
> > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
> > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
> > (if you click on the descriptions you should get more information on
> > what is wrong)
> >
> > You can fix those up and send a v13 and it'll all be clear then ;)
>
> Your information is very helpful, thanks so much!
>
> I will send a v13 later. But I am very curious about why
> conchuod/alphanumeric_selects is failed and what content is in
> this test? Could you please give me some hints about it? ;)
Oh yeah, that output is not very helpful is it. It runs a perl script
that RMK created that tries to put things in the "correct" order before
and after the patch is applied. The script is here:
https://github.com/ConchuOD/nipa/blob/main/tests_rv/patch/alphanumeric_selects/alphanumeric_selects.pl
It also re-orders default/depends on strings, and I assume it's being
tripped up by the config option that you are adding not doing what it
wants you to do with the order of those.
I think you can ignore that one for now.
It's the build errors and SoB issues that I am more interested in
getting fixed ;)
I'll go convert the error level of that to a warning & try to fix up the
reporting that it does.
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 8:18 ` Conor Dooley
@ 2023-02-09 8:40 ` Qinglin Pan
2023-02-09 8:58 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Qinglin Pan @ 2023-02-09 8:40 UTC (permalink / raw)
To: Conor Dooley; +Cc: linux-riscv
Hey!
On 2023/2/9 16:18, Conor Dooley wrote:
> On Thu, Feb 09, 2023 at 04:03:01PM +0800, Qinglin Pan wrote:
>> Hey!
>>
>> On 2023/2/9 15:30, Conor Dooley wrote:
>>> Hey!
>>>
>>> On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
>>>> Hi all,
>>>>
>>>> Sorry for bothering :(
>>>>
>>>> This patchset has a bit of a formatting problem.
>>>> Please use another one:
>>>> https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
>>>
>>> If you're resending, please either mark as RESEND or increment the
>>> version number so that tools don't get confused.
>>> In this case though, tools found some issues with both version
>>> unfortunately:
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
>>> https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
>>> (if you click on the descriptions you should get more information on
>>> what is wrong)
>>>
>>> You can fix those up and send a v13 and it'll all be clear then ;)
>>
>> Your information is very helpful, thanks so much!
>>
>> I will send a v13 later. But I am very curious about why
>> conchuod/alphanumeric_selects is failed and what content is in
>> this test? Could you please give me some hints about it? ;)
>
> Oh yeah, that output is not very helpful is it. It runs a perl script
> that RMK created that tries to put things in the "correct" order before
> and after the patch is applied. The script is here:
> https://github.com/ConchuOD/nipa/blob/main/tests_rv/patch/alphanumeric_selects/alphanumeric_selects.pl
It is what I really need :) :) :)
> It also re-orders default/depends on strings, and I assume it's being
> tripped up by the config option that you are adding not doing what it
> wants you to do with the order of those.
> I think you can ignore that one for now.
>
> It's the build errors and SoB issues that I am more interested in
> getting fixed ;)
>
> I'll go convert the error level of that to a warning & try to fix up the
> reporting that it does.
Thanks a lot for your hard work! ;)
Regards,
Qinglin.
>
> Cheers,
> Conor.
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
2023-02-09 8:40 ` Qinglin Pan
@ 2023-02-09 8:58 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-02-09 8:58 UTC (permalink / raw)
To: Qinglin Pan; +Cc: linux-riscv, bjorn
[-- Attachment #1.1: Type: text/plain, Size: 2877 bytes --]
+CC Bjorn
On Thu, Feb 09, 2023 at 04:40:47PM +0800, Qinglin Pan wrote:
> Hey!
>
> On 2023/2/9 16:18, Conor Dooley wrote:
> > On Thu, Feb 09, 2023 at 04:03:01PM +0800, Qinglin Pan wrote:
> > > Hey!
> > >
> > > On 2023/2/9 15:30, Conor Dooley wrote:
> > > > Hey!
> > > >
> > > > On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
> > > > > Hi all,
> > > > >
> > > > > Sorry for bothering :(
> > > > >
> > > > > This patchset has a bit of a formatting problem.
> > > > > Please use another one:
> > > > > https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
> > > >
> > > > If you're resending, please either mark as RESEND or increment the
> > > > version number so that tools don't get confused.
> > > > In this case though, tools found some issues with both version
> > > > unfortunately:
> > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
> > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
> > > > (if you click on the descriptions you should get more information on
> > > > what is wrong)
> > > >
> > > > You can fix those up and send a v13 and it'll all be clear then ;)
> > >
> > > Your information is very helpful, thanks so much!
> > >
> > > I will send a v13 later. But I am very curious about why
> > > conchuod/alphanumeric_selects is failed and what content is in
> > > this test? Could you please give me some hints about it? ;)
> >
> > Oh yeah, that output is not very helpful is it. It runs a perl script
> > that RMK created that tries to put things in the "correct" order before
> > and after the patch is applied. The script is here:
> > https://github.com/ConchuOD/nipa/blob/main/tests_rv/patch/alphanumeric_selects/alphanumeric_selects.pl
>
> It is what I really need :) :) :)
That perl script will completely re-order the file, so it is run from
another script that just diffs the result with the existing Kconfig
file.
> > It also re-orders default/depends on strings, and I assume it's being
> > tripped up by the config option that you are adding not doing what it
> > wants you to do with the order of those.
> > I think you can ignore that one for now.
> >
> > It's the build errors and SoB issues that I am more interested in
> > getting fixed ;)
> >
> > I'll go convert the error level of that to a warning & try to fix up the
> > reporting that it does.
I think I have fixed this to do something that actually says what it is
complaining about:
https://github.com/ConchuOD/nipa/pull/18
In the future, it'll do something like:
| --- /dev/fd/63 2023-02-09 08:45:10.809992544 +0000
| +++ /dev/fd/62 2023-02-09 08:45:10.809992544 +0000
| @@ -354,0 +355 @@
| + select ARCH_HAS_NOTHING
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-02-09 8:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 3:13 [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime Qinglin Pan
2023-02-09 4:00 ` Qinglin Pan
2023-02-09 7:30 ` Conor Dooley
2023-02-09 8:03 ` Qinglin Pan
2023-02-09 8:18 ` Conor Dooley
2023-02-09 8:40 ` Qinglin Pan
2023-02-09 8:58 ` Conor Dooley
-- strict thread matches above, loose matches on Subject: below --
2023-02-09 3:53 Qinglin Pan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox