From: Conor Dooley <conor@kernel.org>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/3] Documentation: RISC-V: Mention the UEFI Standards
Date: Tue, 20 Sep 2022 18:49:08 +0100 [thread overview]
Message-ID: <Yyn9FJ4iuzJTfO1T@spud> (raw)
In-Reply-To: <20220920140138.27210-3-palmer@rivosinc.com>
On Tue, Sep 20, 2022 at 07:01:41AM -0700, Palmer Dabbelt wrote:
> The current patch acceptance policy requires that specifications are
> approved by the RISC-V foundation, but we rely on external
> specifications as well. This explicitly calls out the UEFI
> specifications that we're starting to depend on.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> This also came up during the Plumbers BoF. The other discussed options
> were to wait for an ACPI/UEFI specification to be published or to just
> not wait at all, but this middle ground matches how we handle the RISC-V
> specifications and it seems like there was broad agreement on it.
>
> As usual with policy stuff I'll wait a bit for others to have a chance
> to chime in, but I think the wording on this one is at least easier to
> reason about than some of the others.
> ---
> Documentation/riscv/patch-acceptance.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/riscv/patch-acceptance.rst b/Documentation/riscv/patch-acceptance.rst
> index 8087718556da..08cb92324eaf 100644
> --- a/Documentation/riscv/patch-acceptance.rst
> +++ b/Documentation/riscv/patch-acceptance.rst
> @@ -20,9 +20,11 @@ Submit Checklist Addendum
> -------------------------
> We'll only accept patches for new modules or extensions if the
> specifications for those modules or extensions are listed as being
> +unlikely to make incompatible changes in the future. For
Nit, but the wording here is awkward since it sounds like the module or
extension is the "actor". How about:
s/make incompatible changes/be incompatibly changed/
> +specifications from the RISC-V foundation this means "Frozen" or
> +"Ratified", for the UEFI specifications this means a published ECR.
> +(Developers may, of course, maintain their own Linux kernel trees that
> +contain code for any draft extensions that they wish.)
Could we just drop the brackets from this sentence?
Either way, policy wise/idealogically this again looks good to me, so
with or without the wording changed:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Additionally, the RISC-V specification allows implementors to create
> their own custom extensions. These custom extensions aren't required
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-20 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 14:01 [PATCH 1/3] Documentation: RISC-V: Fix a typo in patch-acceptance Palmer Dabbelt
2022-09-20 14:01 ` [PATCH 2/3] Documentation: RISC-V: Allow patches for non-standard behavior Palmer Dabbelt
2022-09-20 17:19 ` Conor Dooley
2022-10-13 4:56 ` Palmer Dabbelt
2022-09-20 14:01 ` [PATCH 3/3] Documentation: RISC-V: Mention the UEFI Standards Palmer Dabbelt
2022-09-20 17:49 ` Conor Dooley [this message]
2022-10-13 4:56 ` Palmer Dabbelt
2022-09-26 17:34 ` Atish Patra
2022-10-13 4:56 ` Palmer Dabbelt
2022-09-20 16:56 ` [PATCH 1/3] Documentation: RISC-V: Fix a typo in patch-acceptance Conor Dooley
2022-10-13 4:56 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyn9FJ4iuzJTfO1T@spud \
--to=conor@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox