public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: guoren@kernel.org
Cc: palmer@dabbelt.com, conor@kernel.org, alexghiti@rivosinc.com,
	paul.walmsley@sifive.com, bjorn@rivosinc.com, eobras@redhat.com,
	corbet@lwn.net, peterlin@andestech.com, rabenda.cn@gmail.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH V2 2/2] riscv: errata: Add ERRATA_THEAD_WRITE_ONCE fixup
Date: Mon, 14 Jul 2025 20:02:31 -0700	[thread overview]
Message-ID: <aHXEx2a0qgiPXhBS@x1> (raw)
In-Reply-To: <20250713155321.2064856-3-guoren@kernel.org>

On Sun, Jul 13, 2025 at 11:53:21AM -0400, guoren@kernel.org wrote:
> From: "Guo Ren (Alibaba DAMO Academy)" <guoren@kernel.org>
> 
> The early version of XuanTie C910 core has a store merge buffer
> delay problem. The store merge buffer could improve the store queue
> performance by merging multi-store requests, but when there are not
> continued store requests, the prior single store request would be
> waiting in the store queue for a long time. That would cause
> significant problems for communication between multi-cores. This
> problem was found on sg2042 & th1520 platforms with the qspinlock
> lock torture test.
> 
> So appending a fence w.o could immediately flush the store merge
> buffer and let other cores see the write result.
> 
> This will apply the WRITE_ONCE errata to handle the non-standard
> behavior via appending a fence w.o instruction for WRITE_ONCE().
> 
> This problem is only observed on the sg2042 hardware platform by
> running the lock_torture test program for half an hour. The problem
> was not found in the user space application, because interrupt can
> break the livelock.

The first paragraph states the problem was found on both the SG2042 and
TH1520, but this paragraph states it is only observed on the SG2042. Is
worth me trying to run lock_torture on the TH1520 for many hours?

Thanks,
Drew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-07-15  3:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-13 15:53 [PATCH V2 0/2] riscv: errata: Add ERRATA_THEAD_WRITE_ONCE fixup guoren
2025-07-13 15:53 ` [PATCH V2 1/2] riscv: Move vendor errata definitions to new header guoren
2025-07-15 13:13   ` Han Gao
2025-07-17  8:21   ` Alexandre Ghiti
2025-07-13 15:53 ` [PATCH V2 2/2] riscv: errata: Add ERRATA_THEAD_WRITE_ONCE fixup guoren
2025-07-15  3:02   ` Drew Fustini [this message]
2025-07-15  6:14     ` Guo Ren
2025-07-15 13:14   ` Han Gao
2025-07-17  8:22   ` Alexandre Ghiti
2025-10-07 21:36     ` Han Gao
2025-10-09  7:29       ` Alexandre Ghiti
2025-10-15  3:37         ` Paul Walmsley
2025-10-15  7:53           ` Guo Ren
2025-12-12 16:37           ` Han Gao
2026-01-15 11:10           ` Yao Zi
2025-08-06 17:15 ` [PATCH V2 0/2] " patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHXEx2a0qgiPXhBS@x1 \
    --to=fustini@kernel.org \
    --cc=alexghiti@rivosinc.com \
    --cc=bjorn@rivosinc.com \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=eobras@redhat.com \
    --cc=guoren@kernel.org \
    --cc=leobras@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterlin@andestech.com \
    --cc=rabenda.cn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox