* [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated
@ 2026-04-04 18:55 Osama Abdelkader
2026-04-14 10:15 ` Osama Abdelkader
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2026-04-04 18:55 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Vladimir Kondratiev, Osama Abdelkader, Thomas Gleixner,
linux-riscv, linux-kernel
init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack
or scs_alloc return NULL, call panic() in this case.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
v2:
- call panic() in place instead of return -ENOMEM
---
arch/riscv/kernel/irq.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
index b6af20bc300f..017d42e778be 100644
--- a/arch/riscv/kernel/irq.c
+++ b/arch/riscv/kernel/irq.c
@@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
#endif
-static void init_irq_scs(void)
+static void __init init_irq_scs(void)
{
int cpu;
+ void *s;
if (!scs_is_enabled())
return;
- for_each_possible_cpu(cpu)
- per_cpu(irq_shadow_call_stack_ptr, cpu) =
- scs_alloc(cpu_to_node(cpu));
+ for_each_possible_cpu(cpu) {
+ s = scs_alloc(cpu_to_node(cpu));
+ if (!s)
+ panic("Failed to allocate IRQ shadow call stack resources\n");
+ per_cpu(irq_shadow_call_stack_ptr, cpu) = s;
+ }
}
DEFINE_PER_CPU(ulong *, irq_stack_ptr);
#ifdef CONFIG_VMAP_STACK
-static void init_irq_stacks(void)
+static void __init init_irq_stacks(void)
{
int cpu;
ulong *p;
for_each_possible_cpu(cpu) {
p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu));
+ if (!p)
+ panic("Failed to allocate IRQ stack resources\n");
per_cpu(irq_stack_ptr, cpu) = p;
}
}
@@ -104,7 +110,7 @@ static void init_irq_stacks(void)
/* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */
DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack);
-static void init_irq_stacks(void)
+static void __init init_irq_stacks(void)
{
int cpu;
@@ -129,8 +135,8 @@ void do_softirq_own_stack(void)
#endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */
#else
-static void init_irq_scs(void) {}
-static void init_irq_stacks(void) {}
+static void __init init_irq_scs(void) {}
+static void __init init_irq_stacks(void) {}
#endif /* CONFIG_IRQ_STACKS */
int arch_show_interrupts(struct seq_file *p, int prec)
--
2.43.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated
2026-04-04 18:55 [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated Osama Abdelkader
@ 2026-04-14 10:15 ` Osama Abdelkader
0 siblings, 0 replies; 2+ messages in thread
From: Osama Abdelkader @ 2026-04-14 10:15 UTC (permalink / raw)
To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Vladimir Kondratiev, Thomas Gleixner, linux-riscv, linux-kernel
On Sat, Apr 04, 2026 at 08:55:20PM +0200, Osama Abdelkader wrote:
> init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack
> or scs_alloc return NULL, call panic() in this case.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> v2:
> - call panic() in place instead of return -ENOMEM
> ---
> arch/riscv/kernel/irq.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
> index b6af20bc300f..017d42e778be 100644
> --- a/arch/riscv/kernel/irq.c
> +++ b/arch/riscv/kernel/irq.c
> @@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
> DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
> #endif
>
> -static void init_irq_scs(void)
> +static void __init init_irq_scs(void)
> {
> int cpu;
> + void *s;
>
> if (!scs_is_enabled())
> return;
>
> - for_each_possible_cpu(cpu)
> - per_cpu(irq_shadow_call_stack_ptr, cpu) =
> - scs_alloc(cpu_to_node(cpu));
> + for_each_possible_cpu(cpu) {
> + s = scs_alloc(cpu_to_node(cpu));
> + if (!s)
> + panic("Failed to allocate IRQ shadow call stack resources\n");
> + per_cpu(irq_shadow_call_stack_ptr, cpu) = s;
> + }
> }
>
> DEFINE_PER_CPU(ulong *, irq_stack_ptr);
>
> #ifdef CONFIG_VMAP_STACK
> -static void init_irq_stacks(void)
> +static void __init init_irq_stacks(void)
> {
> int cpu;
> ulong *p;
>
> for_each_possible_cpu(cpu) {
> p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu));
> + if (!p)
> + panic("Failed to allocate IRQ stack resources\n");
> per_cpu(irq_stack_ptr, cpu) = p;
> }
> }
> @@ -104,7 +110,7 @@ static void init_irq_stacks(void)
> /* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */
> DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack);
>
> -static void init_irq_stacks(void)
> +static void __init init_irq_stacks(void)
> {
> int cpu;
>
> @@ -129,8 +135,8 @@ void do_softirq_own_stack(void)
> #endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */
>
> #else
> -static void init_irq_scs(void) {}
> -static void init_irq_stacks(void) {}
> +static void __init init_irq_scs(void) {}
> +static void __init init_irq_stacks(void) {}
> #endif /* CONFIG_IRQ_STACKS */
>
> int arch_show_interrupts(struct seq_file *p, int prec)
> --
> 2.43.0
>
Hi All,
Can you please review?
Best regards,
Osama
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-14 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 18:55 [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated Osama Abdelkader
2026-04-14 10:15 ` Osama Abdelkader
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox