* [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure
@ 2026-07-09 13:58 Pan Chuang
2026-07-09 13:58 ` [PATCH 11/26] dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-09 14:26 ` [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Pan Chuang @ 2026-07-09 13:58 UTC (permalink / raw)
To: Frank Li, Vinod Koul, Keguang Zhang, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Andreas Färber,
Manivannan Sadhasivam, Daniel Mack, Haojian Zhuang,
Robert Jarzmik, Paul Walmsley, Samuel Holland, Geert Uytterhoeven,
Magnus Damm, Orson Zhai, Baolin Wang, Chunyan Zhang,
Patrice Chotard, Amélie Delaunay, Maxime Coquelin,
Alexandre Torgue, Chen-Yu Tsai, Jernej Skrabec, Laxman Dewangan,
Jon Hunter, Thierry Reding, Vignesh Raghavendra, Kunihiko Hayashi,
Masami Hiramatsu, Dmitry Baryshkov, Icenowy Zheng, Kees Cook,
Bjorn Andersson, Pan Chuang, Miaoqian Lin, Jyothi Kumar Seerapu,
Claudiu Beznea, Biju Das, Cosmin Tanislav, John Madieu,
Thomas Andreatta, open list:FREESCALE eDMA DRIVER,
open list:FREESCALE eDMA DRIVER, open list,
open list:MIPS/LOONGSON1 ARCHITECTURE,
moderated list:MEDIATEK DMA DRIVER,
moderated list:MEDIATEK DMA DRIVER,
moderated list:ARM/ACTIONS SEMI ARCHITECTURE,
open list:ARM/QUALCOMM MAILING LIST, open list:SIFIVE DRIVERS,
open list:ARM/RISC-V/RENESAS ARCHITECTURE,
moderated list:STM32 DMA DRIVERS,
open list:ARM/Allwinner sunXi SoC support,
open list:TEGRA ARCHITECTURE SUPPORT
Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
error handling in devm_request_*_irq()") added automatic error logging
to devm_request_threaded_irq() and devm_request_any_context_irq() via
the new devm_request_result() helper. The helper prints device name,
IRQ number, handler functions, and error code on failure.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this automatic
logging.
This series removes the now-redundant dev_err() and dev_err_probe() calls
in dmaengine drivers that follow these devm_request_*_irq() functions,
as the core now provides more detailed diagnostic information on failure.
Pan Chuang (26):
dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
dmaengine: loongson-loongson1-apb-dma: Remove redundant
dev_err()/dev_err_probe()
dmaengine: mediatek-mtk-cqdma: Remove redundant
dev_err()/dev_err_probe()
dmaengine: mediatek-mtk-hsdma: Remove redundant
dev_err()/dev_err_probe()
dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: stm32-stm32-dma3: Remove redundant
dev_err()/dev_err_probe()
dmaengine: stm32-stm32-mdma: Remove redundant
dev_err()/dev_err_probe()
dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
drivers/dma/fsl-edma-main.c | 23 +++++++----------------
drivers/dma/fsl-qdma.c | 4 +---
drivers/dma/loongson/loongson1-apb-dma.c | 4 +---
drivers/dma/mediatek/mtk-cqdma.c | 5 +----
drivers/dma/mediatek/mtk-hsdma.c | 5 +----
drivers/dma/mmp_pdma.c | 4 +---
drivers/dma/moxart-dma.c | 4 +---
drivers/dma/owl-dma.c | 4 +---
drivers/dma/pxa_dma.c | 6 +-----
drivers/dma/qcom/gpi.c | 5 +----
drivers/dma/sf-pdma/sf-pdma.c | 8 ++------
drivers/dma/sh/rcar-dmac.c | 5 +----
drivers/dma/sh/rz-dmac.c | 8 +-------
drivers/dma/sh/shdmac.c | 6 +-----
drivers/dma/sh/usb-dmac.c | 5 +----
drivers/dma/sprd-dma.c | 4 +---
drivers/dma/st_fdma.c | 4 +---
drivers/dma/stm32/stm32-dma.c | 6 +-----
drivers/dma/stm32/stm32-dma3.c | 5 +----
drivers/dma/stm32/stm32-mdma.c | 4 +---
drivers/dma/sun4i-dma.c | 2 +-
drivers/dma/sun6i-dma.c | 4 +---
drivers/dma/tegra20-apb-dma.c | 6 +-----
drivers/dma/ti/edma.c | 8 ++------
drivers/dma/uniphier-xdmac.c | 4 +---
drivers/dma/xgene-dma.c | 5 +----
26 files changed, 34 insertions(+), 114 deletions(-)
--
2.34.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 11/26] dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
2026-07-09 13:58 [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-09 13:58 ` Pan Chuang
2026-07-09 14:26 ` [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Pan Chuang @ 2026-07-09 13:58 UTC (permalink / raw)
To: Paul Walmsley, Samuel Holland, Vinod Koul, Frank Li,
open list:SIFIVE DRIVERS,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM, open list
Cc: Pan Chuang
The devm_request_irq() now automatically logs detailed error messages on
failure. This eliminates the need for driver-specific dev_err() and
dev_err_probe() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/dma/sf-pdma/sf-pdma.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 6f79cc28703e..5e5694750c57 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -411,10 +411,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
r = devm_request_irq(&pdev->dev, irq, sf_pdma_done_isr, 0,
dev_name(&pdev->dev), (void *)chan);
- if (r) {
- dev_err(&pdev->dev, "Fail to attach done ISR: %d\n", r);
+ if (r)
return -EINVAL;
- }
chan->txirq = irq;
@@ -424,10 +422,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
r = devm_request_irq(&pdev->dev, irq, sf_pdma_err_isr, 0,
dev_name(&pdev->dev), (void *)chan);
- if (r) {
- dev_err(&pdev->dev, "Fail to attach err ISR: %d\n", r);
+ if (r)
return -EINVAL;
- }
chan->errirq = irq;
}
--
2.34.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure
2026-07-09 13:58 [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 13:58 ` [PATCH 11/26] dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-09 14:26 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2026-07-09 14:26 UTC (permalink / raw)
To: Pan Chuang
Cc: Frank Li, Vinod Koul, Keguang Zhang, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, Andreas Färber,
Manivannan Sadhasivam, Daniel Mack, Haojian Zhuang,
Robert Jarzmik, Paul Walmsley, Samuel Holland, Geert Uytterhoeven,
Magnus Damm, Orson Zhai, Baolin Wang, Chunyan Zhang,
Patrice Chotard, Amélie Delaunay, Maxime Coquelin,
Alexandre Torgue, Chen-Yu Tsai, Jernej Skrabec, Laxman Dewangan,
Jon Hunter, Thierry Reding, Vignesh Raghavendra, Kunihiko Hayashi,
Masami Hiramatsu, Dmitry Baryshkov, Icenowy Zheng, Kees Cook,
Bjorn Andersson, Miaoqian Lin, Jyothi Kumar Seerapu,
Claudiu Beznea, Biju Das, Cosmin Tanislav, John Madieu,
Thomas Andreatta, open list:FREESCALE eDMA DRIVER,
open list:FREESCALE eDMA DRIVER, open list,
open list:MIPS/LOONGSON1 ARCHITECTURE,
moderated list:MEDIATEK DMA DRIVER,
moderated list:MEDIATEK DMA DRIVER,
moderated list:ARM/ACTIONS SEMI ARCHITECTURE,
open list:ARM/QUALCOMM MAILING LIST, open list:SIFIVE DRIVERS,
open list:ARM/RISC-V/RENESAS ARCHITECTURE,
moderated list:STM32 DMA DRIVERS,
open list:ARM/Allwinner sunXi SoC support,
open list:TEGRA ARCHITECTURE SUPPORT
On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> error handling in devm_request_*_irq()") added automatic error logging
> to devm_request_threaded_irq() and devm_request_any_context_irq() via
> the new devm_request_result() helper. The helper prints device name,
> IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this automatic
> logging.
>
> This series removes the now-redundant dev_err() and dev_err_probe() calls
> in dmaengine drivers that follow these devm_request_*_irq() functions,
> as the core now provides more detailed diagnostic information on failure.
>
> Pan Chuang (26):
> dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
> dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: loongson-loongson1-apb-dma: Remove redundant
> dev_err()/dev_err_probe()
> dmaengine: mediatek-mtk-cqdma: Remove redundant
> dev_err()/dev_err_probe()
> dmaengine: mediatek-mtk-hsdma: Remove redundant
> dev_err()/dev_err_probe()
> dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: stm32-stm32-dma3: Remove redundant
> dev_err()/dev_err_probe()
> dmaengine: stm32-stm32-mdma: Remove redundant
> dev_err()/dev_err_probe()
> dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
> dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
> dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
One patch per subsystem for such trivial changes, please.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-09 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-09 13:58 [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 13:58 ` [PATCH 11/26] dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-09 14:26 ` [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox