From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-riscv@lists.infradead.org
Subject: [RFC PATCH 2/2] riscv: Introduce per cpu based local timer interrupt
Date: Fri, 6 Jul 2018 09:25:44 +0100 [thread overview]
Message-ID: <c7c99f9b-29bf-28f5-1724-9827b4e9c0cf@arm.com> (raw)
In-Reply-To: <20180705222211.GA24936@infradead.org>
On 05/07/18 23:22, hch at infradead.org wrote:
> On Thu, Jul 05, 2018 at 04:58:59PM +0100, Marc Zyngier wrote:
>> Then this is no different from what we have on ARM with GICv1/v2, where
>> private interrupts are strictly private, and cannot be accessed from
>> another CPU.
>
> Ok.
>
>>> I'm not an irqchip expert, but sometimes I really wonder if the irqchip
>>> framework really is the right abstraction for this.
>> Well, it served us pretty well so far. Seems like RISC-V has decided to
>> describe the HW in a subtly (and maybe pointlessly?) different way,
>> rather than reusing the existing abstraction. It is not necessarily bad,
>> but it just makes things more difficult.
>
> As said I'm no expert by any means. The use for the plic controller
> looks fine to me, but writing a driver around a few instructions to
> manage a tiny amount of per-core interrupt state just looks like
> overkill to me.
I'm not advocating one way or another. If people are comfortable with
signalling timer events in a different way than using the irq subsystem,
that's absolutely fine by me. But if they are using existing
abstractions, they should use them correctly.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-07-06 8:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 18:01 [RFC PATCH 0/2] Local timer interrupt fix Atish Patra
2018-06-29 18:01 ` [RFC PATCH 1/2] dt-binding: RISC-V local timer docs Atish Patra
2018-07-02 8:22 ` Marc Zyngier
2018-07-03 18:18 ` Atish Patra
2018-06-29 18:01 ` [RFC PATCH 2/2] riscv: Introduce per cpu based local timer interrupt Atish Patra
2018-07-02 8:31 ` Marc Zyngier
2018-07-03 18:28 ` Atish Patra
2018-07-04 8:24 ` Marc Zyngier
2018-07-05 1:55 ` Atish Patra
2018-07-05 2:17 ` Anup Patel
2018-07-05 7:48 ` Marc Zyngier
2018-07-05 15:42 ` hch at infradead.org
2018-07-05 15:58 ` Marc Zyngier
2018-07-05 22:22 ` hch at infradead.org
2018-07-06 8:25 ` Marc Zyngier [this message]
2018-07-06 9:41 ` Thomas Gleixner
2018-07-06 18:00 ` Atish Patra
2018-08-03 0:14 ` Palmer Dabbelt
2018-07-05 17:15 ` Atish Patra
2018-08-02 21:53 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c99f9b-29bf-28f5-1724-9827b4e9c0cf@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox