From: <Conor.Dooley@microchip.com>
To: <herbert@gondor.apana.org.au>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: hwrng: mpfs - Enable COMPILE_TEST
Date: Fri, 15 Apr 2022 10:20:33 +0000 [thread overview]
Message-ID: <d304baf7-7c7a-8e8f-10a2-b6c6144a2fd8@microchip.com> (raw)
In-Reply-To: <cf6b0236-32d7-09c3-db00-702a2a92bf71@microchip.com>
On 15/04/2022 10:18, Conor.Dooley@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 15/04/2022 08:37, Herbert Xu wrote:
>> The dependency on HW_RANDOM is redundant so this patch removes it.
>> As this driver seems to cross-compile just fine we could also enable
>> COMPILE_TEST.
>
> Sorry about that. Compile test makes sense to me too.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com
woops, missing a >.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks for applying my patch :)
> Conor
>
>>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>>
>> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
>> index 18aa97974b8b..dad084c0ecee 100644
>> --- a/drivers/char/hw_random/Kconfig
>> +++ b/drivers/char/hw_random/Kconfig
>> @@ -387,7 +387,7 @@ config HW_RANDOM_PIC32
>>
>> config HW_RANDOM_POLARFIRE_SOC
>> tristate "Microchip PolarFire SoC Random Number Generator support"
>> - depends on HW_RANDOM && POLARFIRE_SOC_SYS_CTRL
>> + depends on POLARFIRE_SOC_SYS_CTRL || COMPILE_TEST
>> help
>> This driver provides kernel-side support for the Random Number
>> Generator hardware found on PolarFire SoC (MPFS).
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-04-15 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:09 [v2] Add support for hwrng on PolarFire SoC conor.dooley
2022-04-08 10:09 ` [PATCH v2 1/1] hwrng: mpfs - add polarfire soc hwrng support conor.dooley
2022-04-15 8:37 ` hwrng: mpfs - Enable COMPILE_TEST Herbert Xu
2022-04-15 10:18 ` Conor.Dooley
2022-04-15 10:20 ` Conor.Dooley [this message]
2022-04-15 8:40 ` [PATCH v2 1/1] hwrng: mpfs - add polarfire soc hwrng support Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d304baf7-7c7a-8e8f-10a2-b6c6144a2fd8@microchip.com \
--to=conor.dooley@microchip.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox