Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] riscv: defconfig: enable RESET_GPIO driver
       [not found] <CGME20251103140639eucas1p2eed021e71c5f027bf324a9d038f7a9fa@eucas1p2.samsung.com>
@ 2025-11-03 14:06 ` Marek Szyprowski
  2025-11-03 14:58   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2025-11-03 14:06 UTC (permalink / raw)
  To: linux-riscv
  Cc: Marek Szyprowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti, Wolfram Sang, Philipp Zabel, Bartosz Golaszewski

Commit 25d4d4604d01 ("reset: always bail out on missing RESET_GPIO
driver") reworked GPIO-based reset controller initialization, so now
RESET_GPIO driver is required to properly instantiate MMC device for
most of WLAN and SDIO chips.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/riscv/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index fc2725cbca18..e69a27624923 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -263,6 +263,7 @@ CONFIG_PM_DEVFREQ=y
 CONFIG_IIO=y
 CONFIG_PWM=y
 CONFIG_PWM_PXA=m
+CONFIG_RESET_GPIO=y
 CONFIG_THEAD_C900_ACLINT_SSWI=y
 CONFIG_PHY_SUN4I_USB=m
 CONFIG_PHY_STARFIVE_JH7110_DPHY_RX=m
-- 
2.34.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] riscv: defconfig: enable RESET_GPIO driver
  2025-11-03 14:06 ` [PATCH] riscv: defconfig: enable RESET_GPIO driver Marek Szyprowski
@ 2025-11-03 14:58   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-03 14:58 UTC (permalink / raw)
  To: Marek Szyprowski, linux-riscv
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Wolfram Sang, Philipp Zabel, Bartosz Golaszewski

On 03/11/2025 15:06, Marek Szyprowski wrote:
> Commit 25d4d4604d01 ("reset: always bail out on missing RESET_GPIO
> driver") reworked GPIO-based reset controller initialization, so now
> RESET_GPIO driver is required to properly instantiate MMC device for
> most of WLAN and SDIO chips.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Please use patchset concept, so I won't have to send objections to every
subsystem.

No, the 25d4d4604d01 commit is part of broken, non-bisectable patchset
and alone breaks everyone which CANNOT be fixed with defconfig.

All users are affected and that commit must be dropped. I am very
surprised it was just merged without the rest.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-03 14:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20251103140639eucas1p2eed021e71c5f027bf324a9d038f7a9fa@eucas1p2.samsung.com>
2025-11-03 14:06 ` [PATCH] riscv: defconfig: enable RESET_GPIO driver Marek Szyprowski
2025-11-03 14:58   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox