From: Damien Le Moal <dlemoal@kernel.org>
To: zhangjiao2 <zhangjiao2@cmss.chinamobile.com>
Cc: linus.walleij@linaro.org, linux-riscv@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT
Date: Wed, 13 Nov 2024 15:41:34 +0900 [thread overview]
Message-ID: <e3ff8ec3-1995-408d-aa75-6afc11f51ebd@kernel.org> (raw)
In-Reply-To: <20241113063611.5330-1-zhangjiao2@cmss.chinamobile.com>
On 11/13/24 15:36, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> When the temporary macro K210_PC_DEFAULT is no need anymore,
You forgot to fix "no need -> not needed".
And you forgot to add my review tag as well.
> use its name in the #undef statement instead of
> the incorrect "DEFAULT" name.
>
> Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> v2->v3:
> Modify commit info.
>
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index caf20215aaba..eddb01796a83 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
> [K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
> };
>
> -#undef DEFAULT
> +#undef K210_PC_DEFAULT
>
> /*
> * Pin functions configuration information.
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2024-11-13 6:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 6:36 [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT zhangjiao2
2024-11-13 6:41 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ff8ec3-1995-408d-aa75-6afc11f51ebd@kernel.org \
--to=dlemoal@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox