* [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT
@ 2024-11-13 6:36 zhangjiao2
2024-11-13 6:41 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: zhangjiao2 @ 2024-11-13 6:36 UTC (permalink / raw)
To: dlemoal; +Cc: linus.walleij, linux-riscv, linux-gpio, linux-kernel, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
When the temporary macro K210_PC_DEFAULT is no need anymore,
use its name in the #undef statement instead of
the incorrect "DEFAULT" name.
Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
v2->v3:
Modify commit info.
drivers/pinctrl/pinctrl-k210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index caf20215aaba..eddb01796a83 100644
--- a/drivers/pinctrl/pinctrl-k210.c
+++ b/drivers/pinctrl/pinctrl-k210.c
@@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
[K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
};
-#undef DEFAULT
+#undef K210_PC_DEFAULT
/*
* Pin functions configuration information.
--
2.33.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT
2024-11-13 6:36 [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT zhangjiao2
@ 2024-11-13 6:41 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2024-11-13 6:41 UTC (permalink / raw)
To: zhangjiao2; +Cc: linus.walleij, linux-riscv, linux-gpio, linux-kernel
On 11/13/24 15:36, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> When the temporary macro K210_PC_DEFAULT is no need anymore,
You forgot to fix "no need -> not needed".
And you forgot to add my review tag as well.
> use its name in the #undef statement instead of
> the incorrect "DEFAULT" name.
>
> Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> v2->v3:
> Modify commit info.
>
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index caf20215aaba..eddb01796a83 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
> [K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
> };
>
> -#undef DEFAULT
> +#undef K210_PC_DEFAULT
>
> /*
> * Pin functions configuration information.
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-13 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-13 6:36 [PATCH v3] pinctrl: k210: Undef K210_PC_DEFAULT zhangjiao2
2024-11-13 6:41 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox