From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv2 08/13] dt-bindings: mfd: add rk806 binding
Date: Thu, 8 Sep 2022 10:51:46 +0200 [thread overview]
Message-ID: <0a977d86-e137-c328-ce7f-ef7941860936@linaro.org> (raw)
In-Reply-To: <20220908003107.220143-9-sebastian.reichel@collabora.com>
On 08/09/2022 02:31, Sebastian Reichel wrote:
> Add DT binding document for Rockchip's RK806 PMIC.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
Thank you for your patch. There is something to discuss/improve.
> + vcca-supply:
> + description:
> + The input supply for pldo-reg6.
> +
> + regulators:
> + type: object
> + patternProperties:
> + "^(dcdc-reg([1-9]|10)|[pn]ldo_reg[1-6])$":
You still have underscore in the pattern. This should pop-up during
test: please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-08 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 0:30 [PATCHv2 00/13] Introduce RK806 Support Sebastian Reichel
2022-09-08 0:30 ` [PATCHv2 01/13] mfd: rk808: convert to device managed resources Sebastian Reichel
2022-09-08 0:30 ` [PATCHv2 02/13] mfd: rk808: use dev_err_probe Sebastian Reichel
2022-09-08 8:45 ` Robin Murphy
2022-09-08 0:30 ` [PATCHv2 03/13] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel
2022-09-08 0:30 ` [PATCHv2 04/13] regulator: rk808: " Sebastian Reichel
2022-09-08 0:30 ` [PATCHv2 05/13] rtc: " Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 06/13] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 07/13] mfd: rk808: split into core and i2c Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 08/13] dt-bindings: mfd: add rk806 binding Sebastian Reichel
2022-09-08 8:51 ` Krzysztof Kozlowski [this message]
2022-09-08 12:35 ` Rob Herring
2022-09-08 0:31 ` [PATCHv2 09/13] mfd: rk8xx: add rk806 support Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 10/13] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 11/13] regulator: rk808: Use dev_err_probe Sebastian Reichel
2022-09-08 0:31 ` [PATCHv2 12/13] regulator: rk808: add rk806 support Sebastian Reichel
2022-09-08 7:45 ` Matti Vaittinen
2022-09-08 11:31 ` Mark Brown
2022-09-08 0:31 ` [PATCHv2 13/13] ASoC: rk817: Remove 'select REGMAP_I2C' Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a977d86-e137-c328-ce7f-ef7941860936@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox