From: Krzysztof Kozlowski <krzk@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 08/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 3A
Date: Thu, 8 Aug 2024 12:55:21 +0200 [thread overview]
Message-ID: <0e5194c5-9e23-45e9-97a5-8d7441ab7223@kernel.org> (raw)
In-Reply-To: <20240808093808.1740-9-naoki@radxa.com>
On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - move pinctrl properties
> - sort properties
> - add default-state
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index 59f1403b4fa5..4fd6096f16ea 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -42,14 +42,15 @@ gmac1_clkin: external-gmac1-clock {
>
> leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&led_user_en>;
Weird order. names never precede the property.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-08 10:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 9:37 [PATCH 00/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards FUKAUMI Naoki
2024-08-08 9:37 ` [PATCH 01/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi S FUKAUMI Naoki
2024-08-08 10:51 ` Krzysztof Kozlowski
2024-08-08 9:38 ` [PATCH 02/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi E FUKAUMI Naoki
2024-08-08 10:52 ` Krzysztof Kozlowski
2024-08-08 9:38 ` [PATCH 03/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 4C+ FUKAUMI Naoki
2024-08-08 10:52 ` Krzysztof Kozlowski
2024-08-08 9:38 ` [PATCH 04/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi 4 FUKAUMI Naoki
2024-08-08 9:38 ` [PATCH 05/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa CM3 IO FUKAUMI Naoki
2024-08-08 9:38 ` [PATCH 06/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 3C FUKAUMI Naoki
2024-08-08 9:38 ` [PATCH 07/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa E25 FUKAUMI Naoki
2024-08-08 10:54 ` Krzysztof Kozlowski
2024-08-08 17:55 ` Krzysztof Kozlowski
2024-08-08 9:38 ` [PATCH 08/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 3A FUKAUMI Naoki
2024-08-08 10:55 ` Krzysztof Kozlowski [this message]
2024-08-08 9:38 ` [PATCH 09/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 5B FUKAUMI Naoki
2024-08-08 9:38 ` [PATCH 10/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 5A FUKAUMI Naoki
2024-08-08 10:54 ` Krzysztof Kozlowski
2024-08-08 16:46 ` [PATCH 00/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e5194c5-9e23-45e9-97a5-8d7441ab7223@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox