Re: [PATCH 02/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi E

From: Krzysztof Kozlowski <krzk@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 02/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi E
Date: Thu, 8 Aug 2024 12:52:06 +0200	[thread overview]
Message-ID: <711125de-366c-4502-b31a-5ad0fee46c21@kernel.org> (raw)
In-Reply-To: <20240808093808.1740-3-naoki@radxa.com>

On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - sort properties

You mean un-sort?!?!

> - add default-state and function

Commit subject is totally wrong. Sorry, write specific subjects
describing what you are doing. There is no standardization happening
here, whatever that means.

> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> index bb01143dc91a..4e77701f2e01 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> @@ -49,11 +49,13 @@ gmac_clkin: external-gmac-clock {
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		pinctrl-0 = <&led_pin>;
>  		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pin>;

Nope, that's wrong order.

>  

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip