Re: [RFC PATCH v2 2/8] pmdomain/rockchip: add optional per-domain power-on settle delay

From: "Heiko Stübner" <heiko@sntech.de>
To: Jiaxing Hu <gahing@gahingwoo.com>
Cc: tomeu@tomeuvizoso.net, linux-rockchip@lists.infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiaxing Hu <gahing@gahingwoo.com>
Subject: Re: [RFC PATCH v2 2/8] pmdomain/rockchip: add optional per-domain power-on settle delay
Date: Fri, 31 Jul 2026 00:57:33 +0200	[thread overview]
Message-ID: <10568528.L8ug28u51p@diego> (raw)
In-Reply-To: <20260730113239.1417912-1-gahing@gahingwoo.com>

Am Donnerstag, 30. Juli 2026, 13:32:38 Mitteleuropäische Sommerzeit schrieb Jiaxing Hu:
> Hi Heiko,
> 
> Thanks for looking.
> 
> Understood on the naming. The suffixes describe the fields the macro
> sets, so a variant that also carries a wakeup delay should say so. In v3
> I will add
> 
>   DOMAIN_M_O_R_G_W(..., g_mask, delay, wakeup)
> 
> and leave DOMAIN_M_O_R_G with its current signature, with DOMAIN_RK3576
> switched over to the _W form. That also keeps the diff off the macro
> every other SoC goes through, which is nicer than what I sent.
> 
> One note while I am there: DOMAIN_RK3576 is DOMAIN_M_O_R_G's only
> in-tree user, so after this the plain form has no callers left. I will
> keep it as you asked; say the word if you would rather it just gained
> the parameter after all.

Please this ... i.e. not keep the then unused variant around.
As you said RK3576 is the only user, so just rename that DOMAIN_*
macro please.

Heiko

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip