* [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
@ 2018-09-23 12:37 Heiko Stuebner
2018-09-26 12:42 ` Sandy Huang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heiko Stuebner @ 2018-09-23 12:37 UTC (permalink / raw)
To: hjc; +Cc: linux-rockchip, dri-devel
The hs_start interrupt on rk3188 fires at the start of a new frame, so
serves essentially the same purpose as the dsp_hold_valid irq in checking
when the last frame got delivered when going to standby. So define it
to fix a hang on atomic_disable of the vop because the completion never
really completed before.
Fixes: 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
index c482da41bb5d..226bb2a1720e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
@@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = {
};
static const int rk3188_vop_intrs[] = {
- 0,
+ /*
+ * hs_start interrupt fires at frame-start, so serves
+ * the same purpose as dsp_hold in the driver.
+ */
+ DSP_HOLD_VALID_INTR,
FS_INTR,
LINE_FLAG_INTR,
BUS_ERROR_INTR,
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
2018-09-23 12:37 [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent Heiko Stuebner
@ 2018-09-26 12:42 ` Sandy Huang
2018-09-26 12:44 ` Sandy Huang
2018-09-27 10:14 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Sandy Huang @ 2018-09-26 12:42 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, dri-devel
Hi heiko,
nice solution.
Reviewed-by: Sandy Huang <hjc@rock-chips.com>
在 2018/9/23 20:37, Heiko Stuebner 写道:
> The hs_start interrupt on rk3188 fires at the start of a new frame, so
> serves essentially the same purpose as the dsp_hold_valid irq in checking
> when the last frame got delivered when going to standby. So define it
> to fix a hang on atomic_disable of the vop because the completion never
> really completed before.
>
> Fixes: 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> index c482da41bb5d..226bb2a1720e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> @@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = {
> };
>
> static const int rk3188_vop_intrs[] = {
> - 0,
> + /*
> + * hs_start interrupt fires at frame-start, so serves
> + * the same purpose as dsp_hold in the driver.
> + */
> + DSP_HOLD_VALID_INTR,
> FS_INTR,
> LINE_FLAG_INTR,
> BUS_ERROR_INTR,
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
2018-09-23 12:37 [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent Heiko Stuebner
2018-09-26 12:42 ` Sandy Huang
@ 2018-09-26 12:44 ` Sandy Huang
2018-09-27 10:14 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Sandy Huang @ 2018-09-26 12:44 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, dri-devel
Hi heiko,
nice solution.
Reviewed-by: Sandy Huang <hjc@rock-chips.com>
在 2018/9/23 20:37, Heiko Stuebner 写道:
> The hs_start interrupt on rk3188 fires at the start of a new frame, so
> serves essentially the same purpose as the dsp_hold_valid irq in checking
> when the last frame got delivered when going to standby. So define it
> to fix a hang on atomic_disable of the vop because the completion never
> really completed before.
>
> Fixes: 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> index c482da41bb5d..226bb2a1720e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
> @@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = {
> };
>
> static const int rk3188_vop_intrs[] = {
> - 0,
> + /*
> + * hs_start interrupt fires at frame-start, so serves
> + * the same purpose as dsp_hold in the driver.
> + */
> + DSP_HOLD_VALID_INTR,
> FS_INTR,
> LINE_FLAG_INTR,
> BUS_ERROR_INTR,
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
2018-09-23 12:37 [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent Heiko Stuebner
2018-09-26 12:42 ` Sandy Huang
2018-09-26 12:44 ` Sandy Huang
@ 2018-09-27 10:14 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2018-09-27 10:14 UTC (permalink / raw)
To: hjc; +Cc: linux-rockchip, dri-devel
Am Sonntag, 23. September 2018, 14:37:30 CEST schrieb Heiko Stuebner:
> The hs_start interrupt on rk3188 fires at the start of a new frame, so
> serves essentially the same purpose as the dsp_hold_valid irq in checking
> when the last frame got delivered when going to standby. So define it
> to fix a hang on atomic_disable of the vop because the completion never
> really completed before.
>
> Fixes: 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
applied to drm-misc-next with Sandy's Review.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-27 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-23 12:37 [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent Heiko Stuebner
2018-09-26 12:42 ` Sandy Huang
2018-09-26 12:44 ` Sandy Huang
2018-09-27 10:14 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox