Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
	dafna.hirschfeld@collabora.com,  helen.koike@collabora.com,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
	linux-rockchip@lists.infradead.org, tfiga@chromium.org,
	christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v3 1/2] media: rockchip: rkisp1: carry ip version information
Date: Fri, 15 Jan 2021 09:18:36 -0300	[thread overview]
Message-ID: <17998f3e2af82598f0b47015cb959bc3518682b5.camel@collabora.com> (raw)
In-Reply-To: <20210115112351.208011-2-heiko@sntech.de>

Hi Heiko,

Thanks a lot for pushing this.

On Fri, 2021-01-15 at 12:23 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> 
> The IP block evolved from its rk3288/rk3399 base and the vendor
> designates them with a numerical version. rk3399 for example
> is designated V10 probably meaning V1.0.
> 
> There doesn't seem to be an actual version register we could read that
> information from, so allow the match_data to carry that information
> for future differentiation.
> 
> Also carry that information in the hw_revision field of the media-
> controller API, so that userspace also has access to that.
> 
> The added versions are:
> - V10: at least rk3288 + rk3399
> - V11: seemingly unused as of now, but probably appeared in some soc
> - V12: at least rk3326 + px30
> - V13: at least rk1808
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>

Regards,
Ezequiel


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-01-15 12:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 11:23 [PATCH v3 0/2] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-15 11:23 ` [PATCH v3 1/2] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-15 12:18   ` Ezequiel Garcia [this message]
2021-01-15 13:19   ` Dafna Hirschfeld
2021-01-15 14:02   ` Hans Verkuil
2021-01-15 15:41     ` Dafna Hirschfeld
2021-01-15 11:23 ` [PATCH v3 2/2] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-15 12:21   ` Ezequiel Garcia
2021-01-15 13:20     ` Dafna Hirschfeld
2021-01-15 14:13   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17998f3e2af82598f0b47015cb959bc3518682b5.camel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox