From: Ezequiel Garcia <ezequiel@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
linux-rockchip@lists.infradead.org, tfiga@chromium.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v3 2/2] media: rockchip: rkisp1: extend uapi array sizes
Date: Fri, 15 Jan 2021 09:21:25 -0300 [thread overview]
Message-ID: <d194755d07ee6949d6577d8d08402548dbcd75cc.camel@collabora.com> (raw)
In-Reply-To: <20210115112351.208011-3-heiko@sntech.de>
On Fri, 2021-01-15 at 12:23 +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> Later variants of the rkisp1 block use more entries in some arrays:
>
> RKISP1_CIF_ISP_AE_MEAN_MAX 25 -> 81
> RKISP1_CIF_ISP_HIST_BIN_N_MAX 16 -> 32
> RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES 17 -> 34
> RKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE 28 -> 81
>
> and we can still extend the uapi during the 5.11-rc cycle, so do that
> now to be on the safe side.
>
> V10 and V11 only need the smaller sizes, while V12 and V13 needed
> the larger sizes.
>
> When adding the bigger sizes make sure, values filled from hardware
> values and transmitted to userspace don't leak kernel data by zeroing
> them beforehand.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Thanks,
Ezequiel
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-01-15 12:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 11:23 [PATCH v3 0/2] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-15 11:23 ` [PATCH v3 1/2] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-15 12:18 ` Ezequiel Garcia
2021-01-15 13:19 ` Dafna Hirschfeld
2021-01-15 14:02 ` Hans Verkuil
2021-01-15 15:41 ` Dafna Hirschfeld
2021-01-15 11:23 ` [PATCH v3 2/2] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-15 12:21 ` Ezequiel Garcia [this message]
2021-01-15 13:20 ` Dafna Hirschfeld
2021-01-15 14:13 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d194755d07ee6949d6577d8d08402548dbcd75cc.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox