From: "Heiko Stübner" <heiko@sntech.de>
To: Vincent Legoll <vincent.legoll@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-rockchip@lists.infradead.org
Subject: Re: rk3588 tsadc
Date: Wed, 14 Jun 2023 17:17:48 +0200 [thread overview]
Message-ID: <1845724.3VsfAaAtOV@diego> (raw)
In-Reply-To: <20230614151245.zi45j7zxsewagosm@mercury.elektranox.org>
Am Mittwoch, 14. Juni 2023, 17:12:45 CEST schrieb Sebastian Reichel:
> Hello Vincent,
>
> On Wed, Jun 14, 2023 at 02:56:31PM +0000, Vincent Legoll wrote:
> > when testing the latest collabora rk3588 branch, I see the
> > following kernel message:
> >
> > rockchip-thermal fec00000.tsadc: Missing rockchip,grf property
> >
> > Is this something on my end or is the
> > arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > file missing a rockchip,grf line ?
>
> No, that is fine. The RK3588 is one of the chips where this comment
> applies:
>
> /* The tsadc wont to handle the error in here since some SoCs didn't
> * need this property.
> */
> thermal->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
> if (IS_ERR(thermal->grf))
> dev_warn(dev, "Missing rockchip,grf property\n");
>
> Maybe we should add 'bool grf_needed' to 'struct rockchip_tsadc_chip'
> and make this mandatory on platforms needing the GRF and not
> requested at all on the other platforms to reduce confusion.
sounds like a good idea, though looking through the instances it looks
like all grf-uses are guarded by a "if (!IS_ERR(grf))" and handle differently
when no GRF link is present.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-06-14 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:56 rk3588 tsadc Vincent Legoll
2023-06-14 15:12 ` Sebastian Reichel
2023-06-14 15:17 ` Heiko Stübner [this message]
2023-06-14 15:16 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1845724.3VsfAaAtOV@diego \
--to=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=sebastian.reichel@collabora.com \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox