public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	linux-rockchip@lists.infradead.org,
	Vincent Legoll <vincent.legoll@gmail.com>
Subject: Re: rk3588 tsadc
Date: Wed, 14 Jun 2023 17:16:01 +0200	[thread overview]
Message-ID: <2669725.k3LOHGUjKi@diego> (raw)
In-Reply-To: <CAEwRq=oddAzJcVBhxJVe9QActLe30cPdnzhGormv6xr8nu6RXg@mail.gmail.com>

Hi,

Am Mittwoch, 14. Juni 2023, 16:56:31 CEST schrieb Vincent Legoll:
> when testing the latest collabora rk3588 branch, I see the
> following kernel message:
> 
> rockchip-thermal fec00000.tsadc: Missing rockchip,grf property
> 
> Is this something on my end or is the
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> file missing a rockchip,grf line ?

In the thermal adc, the GRF is optional, so not required.

The code for the rk3588 defines a tsadc register RK3588_GRF0_TSADC_TRM
that is used to define the way to shutdown in an over-temp case.

Though right now the code doesn't use it.


So on a technical side, there is nothing going wrong right now ;-) .
Though I guess the message could get an improvement to say something
like "Missing optional rockchip,grf property" ... adding the optional in.

And of course someone could still add the grf prop to the rk3588 dt
for future use of the existing defines.


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

      parent reply	other threads:[~2023-06-14 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:56 rk3588 tsadc Vincent Legoll
2023-06-14 15:12 ` Sebastian Reichel
2023-06-14 15:17   ` Heiko Stübner
2023-06-14 15:16 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2669725.k3LOHGUjKi@diego \
    --to=heiko@sntech.de \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox