rk3588 tsadc

rk3588 tsadc

[Vincent Legoll]

Hello,

when testing the latest collabora rk3588 branch, I see the
following kernel message:

rockchip-thermal fec00000.tsadc: Missing rockchip,grf property

Is this something on my end or is the
arch/arm64/boot/dts/rockchip/rk3588s.dtsi
file missing a rockchip,grf line ?

Thanks

-- 
Vincent Legoll

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: rk3588 tsadc

[Sebastian Reichel]

[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

Hello Vincent,

On Wed, Jun 14, 2023 at 02:56:31PM +0000, Vincent Legoll wrote:
> when testing the latest collabora rk3588 branch, I see the
> following kernel message:
> 
> rockchip-thermal fec00000.tsadc: Missing rockchip,grf property
> 
> Is this something on my end or is the
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> file missing a rockchip,grf line ?

No, that is fine. The RK3588 is one of the chips where this comment
applies:

	/* The tsadc wont to handle the error in here since some SoCs didn't
	 * need this property.
	 */
	thermal->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
	if (IS_ERR(thermal->grf))
		dev_warn(dev, "Missing rockchip,grf property\n");

Maybe we should add 'bool grf_needed' to 'struct rockchip_tsadc_chip'
and make this mandatory on platforms needing the GRF and not
requested at all on the other platforms to reduce confusion.

Greetings,

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: rk3588 tsadc

[Heiko Stübner]

Hi,

Am Mittwoch, 14. Juni 2023, 16:56:31 CEST schrieb Vincent Legoll:
> when testing the latest collabora rk3588 branch, I see the
> following kernel message:
> 
> rockchip-thermal fec00000.tsadc: Missing rockchip,grf property
> 
> Is this something on my end or is the
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> file missing a rockchip,grf line ?

In the thermal adc, the GRF is optional, so not required.

The code for the rk3588 defines a tsadc register RK3588_GRF0_TSADC_TRM
that is used to define the way to shutdown in an over-temp case.

Though right now the code doesn't use it.


So on a technical side, there is nothing going wrong right now ;-) .
Though I guess the message could get an improvement to say something
like "Missing optional rockchip,grf property" ... adding the optional in.

And of course someone could still add the grf prop to the rk3588 dt
for future use of the existing defines.


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: rk3588 tsadc

[Heiko Stübner]

Am Mittwoch, 14. Juni 2023, 17:12:45 CEST schrieb Sebastian Reichel:
> Hello Vincent,
> 
> On Wed, Jun 14, 2023 at 02:56:31PM +0000, Vincent Legoll wrote:
> > when testing the latest collabora rk3588 branch, I see the
> > following kernel message:
> > 
> > rockchip-thermal fec00000.tsadc: Missing rockchip,grf property
> > 
> > Is this something on my end or is the
> > arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > file missing a rockchip,grf line ?
> 
> No, that is fine. The RK3588 is one of the chips where this comment
> applies:
> 
> 	/* The tsadc wont to handle the error in here since some SoCs didn't
> 	 * need this property.
> 	 */
> 	thermal->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
> 	if (IS_ERR(thermal->grf))
> 		dev_warn(dev, "Missing rockchip,grf property\n");
> 
> Maybe we should add 'bool grf_needed' to 'struct rockchip_tsadc_chip'
> and make this mandatory on platforms needing the GRF and not
> requested at all on the other platforms to reduce confusion.

sounds like a good idea, though looking through the instances it looks
like all grf-uses are guarded by a "if (!IS_ERR(grf))" and handle differently
when no GRF link is present.



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip