From: "Heiko Stübner" <heiko@sntech.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR
Date: Fri, 16 Aug 2024 13:29:27 +0200 [thread overview]
Message-ID: <1894793.tdWV9SEqCh@diego> (raw)
In-Reply-To: <7AA0A63882CF1421+db730266-394c-4823-afa6-8595d40daa18@radxa.com>
Hi,
Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki:
> thank you very much for your review.
>
> but, I decided not to use "pwm-leds-multicolor" for Radxa E25.
> please ignore this patch series.
What Krzysztof meant was probably more in line of that a commit message
should not explain what the commit does, because that can be seen in the
code.
Instead the commit message should explain why that change is needed.
> really sorry.
>
> Best regards,
>
> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
>
> On 8/16/24 14:18, Krzysztof Kozlowski wrote:
> > On 16/08/2024 04:32, FUKAUMI Naoki wrote:
> >> enable "pwm-leds-multicolor" driver.
> >
> > Why?
> >
> > Best regards,
> > Krzysztof
> >
> >
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-16 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 2:32 [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR FUKAUMI Naoki
2024-08-16 2:32 ` [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 FUKAUMI Naoki
2024-08-16 2:40 ` FUKAUMI Naoki
2024-08-16 5:18 ` [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR Krzysztof Kozlowski
2024-08-16 11:06 ` FUKAUMI Naoki
2024-08-16 11:29 ` Heiko Stübner [this message]
2024-08-16 12:00 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894793.tdWV9SEqCh@diego \
--to=heiko@sntech.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox