* [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR @ 2024-08-16 2:32 FUKAUMI Naoki 2024-08-16 2:32 ` [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 FUKAUMI Naoki 2024-08-16 5:18 ` [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR Krzysztof Kozlowski 0 siblings, 2 replies; 7+ messages in thread From: FUKAUMI Naoki @ 2024-08-16 2:32 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip, FUKAUMI Naoki enable "pwm-leds-multicolor" driver. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index b14cc106e4f7..725eaadc22a9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1171,6 +1171,7 @@ CONFIG_LEDS_PCA9532=m CONFIG_LEDS_GPIO=y CONFIG_LEDS_PWM=y CONFIG_LEDS_SYSCON=y +CONFIG_LEDS_PWM_MULTICOLOR=m CONFIG_LEDS_QCOM_LPG=m CONFIG_LEDS_TRIGGER_TIMER=y CONFIG_LEDS_TRIGGER_DISK=y -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 2024-08-16 2:32 [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR FUKAUMI Naoki @ 2024-08-16 2:32 ` FUKAUMI Naoki 2024-08-16 2:40 ` FUKAUMI Naoki 2024-08-16 5:18 ` [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR Krzysztof Kozlowski 1 sibling, 1 reply; 7+ messages in thread From: FUKAUMI Naoki @ 2024-08-16 2:32 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip, FUKAUMI Naoki Radxa E25 carrier board has 16x RGB PWM LEDs. This patch make it controllable under sysfs. $ ls /sys/class/leds/rgb\:status brightness max_brightness multi_intensity subsystem uevent device multi_index power trigger Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts index 72ad74c38a2b..1eaf304d94b9 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts @@ -16,6 +16,7 @@ pwm-leds { multi-led { color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; max-brightness = <255>; led-red { -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 2024-08-16 2:32 ` [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 FUKAUMI Naoki @ 2024-08-16 2:40 ` FUKAUMI Naoki 0 siblings, 0 replies; 7+ messages in thread From: FUKAUMI Naoki @ 2024-08-16 2:40 UTC (permalink / raw) To: heiko Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip Hi, sorry, commit message was not correct. I'll fix it in v2. -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/16/24 11:32, FUKAUMI Naoki wrote: > Radxa E25 carrier board has 16x RGB PWM LEDs. This patch make it > controllable under sysfs. > > $ ls /sys/class/leds/rgb\:status > brightness max_brightness multi_intensity subsystem uevent > device multi_index power trigger > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts > index 72ad74c38a2b..1eaf304d94b9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts > @@ -16,6 +16,7 @@ pwm-leds { > > multi-led { > color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_STATUS; > max-brightness = <255>; > > led-red { _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR 2024-08-16 2:32 [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR FUKAUMI Naoki 2024-08-16 2:32 ` [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 FUKAUMI Naoki @ 2024-08-16 5:18 ` Krzysztof Kozlowski 2024-08-16 11:06 ` FUKAUMI Naoki 1 sibling, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-08-16 5:18 UTC (permalink / raw) To: FUKAUMI Naoki, heiko Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip On 16/08/2024 04:32, FUKAUMI Naoki wrote: > enable "pwm-leds-multicolor" driver. Why? Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR 2024-08-16 5:18 ` [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR Krzysztof Kozlowski @ 2024-08-16 11:06 ` FUKAUMI Naoki 2024-08-16 11:29 ` Heiko Stübner 0 siblings, 1 reply; 7+ messages in thread From: FUKAUMI Naoki @ 2024-08-16 11:06 UTC (permalink / raw) To: Krzysztof Kozlowski, heiko Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip Hi, thank you very much for your review. but, I decided not to use "pwm-leds-multicolor" for Radxa E25. please ignore this patch series. really sorry. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/16/24 14:18, Krzysztof Kozlowski wrote: > On 16/08/2024 04:32, FUKAUMI Naoki wrote: >> enable "pwm-leds-multicolor" driver. > > Why? > > Best regards, > Krzysztof > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR 2024-08-16 11:06 ` FUKAUMI Naoki @ 2024-08-16 11:29 ` Heiko Stübner 2024-08-16 12:00 ` FUKAUMI Naoki 0 siblings, 1 reply; 7+ messages in thread From: Heiko Stübner @ 2024-08-16 11:29 UTC (permalink / raw) To: Krzysztof Kozlowski, FUKAUMI Naoki Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip Hi, Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki: > thank you very much for your review. > > but, I decided not to use "pwm-leds-multicolor" for Radxa E25. > please ignore this patch series. What Krzysztof meant was probably more in line of that a commit message should not explain what the commit does, because that can be seen in the code. Instead the commit message should explain why that change is needed. > really sorry. > > Best regards, > > -- > FUKAUMI Naoki > Radxa Computer (Shenzhen) Co., Ltd. > > On 8/16/24 14:18, Krzysztof Kozlowski wrote: > > On 16/08/2024 04:32, FUKAUMI Naoki wrote: > >> enable "pwm-leds-multicolor" driver. > > > > Why? > > > > Best regards, > > Krzysztof > > > > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR 2024-08-16 11:29 ` Heiko Stübner @ 2024-08-16 12:00 ` FUKAUMI Naoki 0 siblings, 0 replies; 7+ messages in thread From: FUKAUMI Naoki @ 2024-08-16 12:00 UTC (permalink / raw) To: Heiko Stübner, Krzysztof Kozlowski Cc: robh, krzk+dt, conor+dt, catalin.marinas, will, devicetree, linux-rockchip Hi, On 8/16/24 20:29, Heiko Stübner wrote: > Hi, > > Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki: >> thank you very much for your review. >> >> but, I decided not to use "pwm-leds-multicolor" for Radxa E25. >> please ignore this patch series. > > What Krzysztof meant was probably more in line of that a commit message > should not explain what the commit does, because that can be seen in the > code. > > Instead the commit message should explain why that change is needed. I see, but there is no reason to use "pwm-leds-multicolor" anymore, please ignore this patch series. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> really sorry. >> >> Best regards, >> >> -- >> FUKAUMI Naoki >> Radxa Computer (Shenzhen) Co., Ltd. >> >> On 8/16/24 14:18, Krzysztof Kozlowski wrote: >>> On 16/08/2024 04:32, FUKAUMI Naoki wrote: >>>> enable "pwm-leds-multicolor" driver. >>> >>> Why? >>> >>> Best regards, >>> Krzysztof >>> >>> >> >> > > > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-16 12:01 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-08-16 2:32 [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR FUKAUMI Naoki 2024-08-16 2:32 ` [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25 FUKAUMI Naoki 2024-08-16 2:40 ` FUKAUMI Naoki 2024-08-16 5:18 ` [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR Krzysztof Kozlowski 2024-08-16 11:06 ` FUKAUMI Naoki 2024-08-16 11:29 ` Heiko Stübner 2024-08-16 12:00 ` FUKAUMI Naoki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox