From: Francois Romieu <romieu@fr.zoreil.com>
To: Shuyu Wei <wsy2220@gmail.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
David Miller <davem@davemloft.net>,
wxt@rock-chips.com, heiko@sntech.de,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer
Date: Sat, 21 May 2016 21:47:33 +0200 [thread overview]
Message-ID: <20160521194733.GA30557@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20160521160910.GA14945@debian-dorm>
Shuyu Wei <wsy2220@gmail.com> :
[...]
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index a3a9392..c2447b0 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
> @@ -686,6 +686,9 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev)
>
> skb_tx_timestamp(skb);
>
> + /* Make sure timestamp is set */
> + smp_wmb();
Should be dma_wmb() (see davem's message).
It's completely unrelated to SMP.
--
Ueimor
next prev parent reply other threads:[~2016-05-21 19:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 15:25 [PATCH v2] ethernet:arc: Fix racing of TX ring buffer Shuyu Wei
2016-05-17 16:36 ` Aw: " Lino Sanfilippo
2016-05-17 18:24 ` David Miller
[not found] ` <20160517.142456.2247845107325931733.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-05-18 0:01 ` Francois Romieu
[not found] ` <20160518000153.GA21757-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org>
2016-05-18 20:29 ` Lino Sanfilippo
[not found] ` <573CD09D.1060307-Mmb7MZpHnFY@public.gmane.org>
2016-05-18 22:55 ` Francois Romieu
[not found] ` <20160518225529.GA18671-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org>
2016-05-19 21:15 ` Lino Sanfilippo
[not found] ` <573E2D0C.604-Mmb7MZpHnFY@public.gmane.org>
2016-05-20 0:31 ` Francois Romieu
2016-05-21 16:09 ` Shuyu Wei
2016-05-21 19:47 ` Francois Romieu [this message]
[not found] ` <20160521194733.GA30557-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org>
2016-05-21 23:04 ` Lino Sanfilippo
[not found] ` <5740E98A.5050803-Mmb7MZpHnFY@public.gmane.org>
2016-05-22 21:21 ` Francois Romieu
2016-05-21 22:58 ` Lino Sanfilippo
2016-05-22 9:17 ` Shuyu Wei
2016-05-22 11:30 ` Lino Sanfilippo
[not found] ` <57419853.9050701-Mmb7MZpHnFY@public.gmane.org>
2016-05-22 22:36 ` Francois Romieu
[not found] ` <20160522223659.GB5086-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org>
2016-05-24 1:09 ` Lino Sanfilippo
[not found] ` <5743A9DD.8010202-Mmb7MZpHnFY@public.gmane.org>
2016-05-24 19:02 ` Francois Romieu
2016-05-24 23:56 ` Lino Sanfilippo
2016-05-28 6:43 ` Shuyu Wei
2016-05-30 21:41 ` Lino Sanfilippo
2016-06-05 14:02 ` Shuyu Wei
2016-06-08 7:54 ` Lino Sanfilippo
2016-05-23 11:36 ` Shuyu Wei
2016-05-24 1:14 ` Lino Sanfilippo
2016-05-21 13:46 ` Shuyu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160521194733.GA30557@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=LinoSanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=wsy2220@gmail.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox